在 C 中对命令行输入进行标记

发布于 2024-10-31 05:34:10 字数 687 浏览 5 评论 0原文

尝试获取一行文本并将其标记为 execvp() 的文件名和参数。这是我的代码，getArguments() 是损坏的函数。目前，尝试打印 arguments[0] 会导致总线错误。

char* getFilename(char* input) {
    return strtok(input, " &");
}

char** getArguments(char* input) {
    char** arguments;
    int k = 0;
    char* tokenized;
    tokenized = strtok(input, " &");
    tokenized = strtok(NULL, " &");
    while (tokenized != NULL) {
        arguments[k] = tokenized;
        ++k;
        tokenized = strtok(NULL, " &");
    }
    return arguments;
}

我稍后在代码中按以下方式使用它：

char* filename = getFilename(line);
char** arguments = getArguments(line);

原文

trying to take a line of text and tokenize it into a filename and arguments for execvp(). Here's my code, getArguments() is the broken function. Currently, trying to print arguments[0] results in a bus error.

char* getFilename(char* input) {
    return strtok(input, " &");
}

char** getArguments(char* input) {
    char** arguments;
    int k = 0;
    char* tokenized;
    tokenized = strtok(input, " &");
    tokenized = strtok(NULL, " &");
    while (tokenized != NULL) {
        arguments[k] = tokenized;
        ++k;
        tokenized = strtok(NULL, " &");
    }
    return arguments;
}

I am using it in the following manner later in my code:

char* filename = getFilename(line);
char** arguments = getArguments(line);

分享到QQ

分享到微博

如果你对这篇内容有疑问，欢迎到本站社区发帖提问参与讨论，获取更多帮助，或者扫码二维码加入 Web 技术交流群。

发布评论

需要登录才能够评论，你可以免费注册一个本站的账号。

苏大泽ㄣ 2024-11-07 05:34:10

对 getFilename 的调用通过在第一个标记后面放置“\0”字符来修改字符串。然后您尝试在 getArguments 中从头开始重新启动。由于字符串现在提前终止，因此只会产生第一个标记。您可以通过摆脱 getFilename 并从 getArguments 获取它来解决此问题。

char **arguments = getArguments(line);
char *filename = arguments[0];

此外，您必须为 char **arguments; 数组中的每个指针分配空间。您可以使用 realloc 动态增长数组。然而，还有更有效的方法。

char** getArguments(char* input) {
    char** arguments;
    int k = 0;
    char* tokenized;
    arguments = calloc(1, sizeof (char *));
    tokenized = strtok(input, " &");
    /* don't eat the first token here since we want the filename in arguments */
    while (tokenized != NULL) {
        arguments[k] = tokenized;
        ++k;
        arguments = realloc(arguments, sizeof (char *) * (k + 1));            
        tokenized = strtok(NULL, " &");
    }

    /* an extra NULL is required to terminate the array for execvp() */
    arguments[k] = NULL;

    return arguments;
}

The call to getFilename modifies the string by placing a '\0' character after the first token. Then you attempt to restart at the beginning in getArguments. That only yields the first token since the string is now prematurely terminated. You can fix this problem by getting rid of getFilename and getting it from getArguments.

char **arguments = getArguments(line);
char *filename = arguments[0];

Also, you must allocate space for each pointer in the char **arguments; array. You can use realloc to grow the array dynamically. However, there are more efficient approaches.

char** getArguments(char* input) {
    char** arguments;
    int k = 0;
    char* tokenized;
    arguments = calloc(1, sizeof (char *));
    tokenized = strtok(input, " &");
    /* don't eat the first token here since we want the filename in arguments */
    while (tokenized != NULL) {
        arguments[k] = tokenized;
        ++k;
        arguments = realloc(arguments, sizeof (char *) * (k + 1));            
        tokenized = strtok(NULL, " &");
    }

    /* an extra NULL is required to terminate the array for execvp() */
    arguments[k] = NULL;

    return arguments;
}

回复收藏 0 原文