如何将一个大功能分为PHP中的小功能以获得最佳实践？

Question

我创建了一个功能 exportFile ，将文件导出到.csv and .txt中的Amazon，Magento和来自数据库中的捕获量。既然，由于较长的标题以及一些重复的循环，该功能变得越来越大，如何将此功能分为单独的功能以获得最佳实践？

function exportFile ($fileName, $platform, $option) {
    $test_db = new MysqliDb (TEST_DB_HOSTNAME, TEST_DB_USERNAME, TEST_DB_PASSWORD, TEST_DB_DATABASE);
    
    $file = fopen(DOWNLOAD_FILE_PATH.$fileName, 'wb') OR die(json_encode(array("status" => "error", "errMessage" => "Error while downloading file!")));
    if ($file) {
        $query = "SELECT * FROM database";
        $data = $test_db->rawQuery($query);

        switch ($platform) {
               case 'magento':
               $header = array(
                    #csv titles goes here
               );
               fputcsv($file, $header);
               foreach ($data as $rows) {
                  $csvData = array(
                      #csv records from database goes here
                  );
                  fputcsv($file, $csvData);
               }
               break;
               case 'catch':
               $header = array(
                    #csv titles goes here but not same as magento 
               );
               fputcsv($file, $header);
               foreach ($data as $rows) {
                  $csvData = array(
                      #csv records from database goes here but not same as magento
                  );
                  fputcsv($file, $csvData);
               }
               break;
            }
        }
 }

Answer 1

有很多方法可以分解事物。这是一个起动器，

function fileOpen {$filename}
{  return fopen(DOWNLOAD_FILE_PATH.$fileName, 'wb') OR
          die(json_encode(array("status" => "error", "errMessage" => "Error while downloading file!")));
}

function getData ()
{
  $test_db = new MysqliDb (TEST_DB_HOSTNAME, TEST_DB_USERNAME, TEST_DB_PASSWORD, TEST_DB_DATABASE);
  $query = "SELECT * FROM database";
  return $test_db->rawQuery($query);
}

function doMagento ($file, &$data)
{
   $header = array(
        #csv titles goes here
   );
   fputcsv($file, $header);
   foreach ($data as $rows) {
      $csvData = array(
          #csv records from database goes here
      );
      fputcsv($file, $csvData);
   }
}

function doCatch ($file, &$data)
{
   $header = array(
        #csv titles goes here but not same as magento
   );
   fputcsv($file, $header);
   foreach ($data as $rows) {
      $csvData = array(
          #csv records from database goes here but not same as magento
      );
      fputcsv($file, $csvData);
   }
}

function exportFile ($fileName, $platform, $option) {

    $file = fileOpen ($filename);
    if ($file) {
        $data = getData ();

        switch ($platform) {
               case 'magento': doMagento ($file, $data);
                               break;
               case 'catch':   doCatch ($file, $data);
                               break;
            }
        }
 }

需要再迭代才能为CSVDATA创建功能。那是你要做的！