通过参考的字符串正常工作,而不是在LCS问题中
如果我在函数方法中传递字符串引用,则它的工作正常,但是如果我不通过参考传递,则测试用例将失败,超过时间限制。 谁能告诉我我想念什么?
工作代码:
class Solution {
public:
int lcsUtil(string& s1,int ind1,string& s2,int ind2,vector< vector<int>>&dp){
if(ind1<0 || ind2<0) return 0;
if(dp[ind1][ind2] != -1) return dp[ind1][ind2];
if(s1[ind1] == s2[ind2])
return dp[ind1][ind2] = 1 + lcsUtil(s1,ind1-1,s2,ind2-1,dp);
else
return dp[ind1][ind2] = 0 + max(lcsUtil(s1,ind1-1,s2,ind2,dp),lcsUtil(s1,ind1,s2,ind2-1,dp));
}
int longestCommonSubsequence(string text1, string text2) {
vector< vector<int> > dp (text1.size(),vector<int>(text2.size(),-1));
return lcsUtil(text1,text1.size()-1,text2,text2.size()-1,dp);
}
};
不工作代码:
class Solution {
public:
int lcsUtil(string s1,int ind1,string s2,int ind2,vector< vector<int>>&dp){
if(ind1<0 || ind2<0) return 0;
if(dp[ind1][ind2] != -1) return dp[ind1][ind2];
if(s1[ind1] == s2[ind2])
return dp[ind1][ind2] = 1 + lcsUtil(s1,ind1-1,s2,ind2-1,dp);
else
return dp[ind1][ind2] = 0 + max(lcsUtil(s1,ind1-1,s2,ind2,dp),lcsUtil(s1,ind1,s2,ind2-1,dp));
}
int longestCommonSubsequence(string text1, string text2) {
vector< vector<int> > dp (text1.size(),vector<int>(text2.size(),-1));
return lcsUtil(text1,text1.size()-1,text2,text2.size()-1,dp);
}
};
问题statment
https://leetcode.com/problems/problems/longongest-est-est-est-est-est-----公共序列/
If I am passing the string reference in the function method then it is working fine, but if I am not passing it by reference then the test cases are failing with time limit exceeded.
Can anyone please tell me what am I missing ?
Working code:
class Solution {
public:
int lcsUtil(string& s1,int ind1,string& s2,int ind2,vector< vector<int>>&dp){
if(ind1<0 || ind2<0) return 0;
if(dp[ind1][ind2] != -1) return dp[ind1][ind2];
if(s1[ind1] == s2[ind2])
return dp[ind1][ind2] = 1 + lcsUtil(s1,ind1-1,s2,ind2-1,dp);
else
return dp[ind1][ind2] = 0 + max(lcsUtil(s1,ind1-1,s2,ind2,dp),lcsUtil(s1,ind1,s2,ind2-1,dp));
}
int longestCommonSubsequence(string text1, string text2) {
vector< vector<int> > dp (text1.size(),vector<int>(text2.size(),-1));
return lcsUtil(text1,text1.size()-1,text2,text2.size()-1,dp);
}
};
Not working code:
class Solution {
public:
int lcsUtil(string s1,int ind1,string s2,int ind2,vector< vector<int>>&dp){
if(ind1<0 || ind2<0) return 0;
if(dp[ind1][ind2] != -1) return dp[ind1][ind2];
if(s1[ind1] == s2[ind2])
return dp[ind1][ind2] = 1 + lcsUtil(s1,ind1-1,s2,ind2-1,dp);
else
return dp[ind1][ind2] = 0 + max(lcsUtil(s1,ind1-1,s2,ind2,dp),lcsUtil(s1,ind1,s2,ind2-1,dp));
}
int longestCommonSubsequence(string text1, string text2) {
vector< vector<int> > dp (text1.size(),vector<int>(text2.size(),-1));
return lcsUtil(text1,text1.size()-1,text2,text2.size()-1,dp);
}
};
Problem statment
如果你对这篇内容有疑问,欢迎到本站社区发帖提问 参与讨论,获取更多帮助,或者扫码二维码加入 Web 技术交流群。

绑定邮箱获取回复消息
由于您还没有绑定你的真实邮箱,如果其他用户或者作者回复了您的评论,将不能在第一时间通知您!
发布评论
评论(1)
当您按值 s传递
std :: string
s,就像在第二个示例中一样,每次都要复制它们。这需要时间(和内存),并解释了超出限制。您也可能无法超过内存限制。当您通过参考将它们传递时,您不会制作字符串的副本。而是引用已经存在的字符串。When you pass
std::string
s by value, like you do in your second example, you copy them every time. That takes time (and memory) and explains the limit exceeded. You could also have failed on exceeding the memory limit. When you pass them by reference, you don't make a copy of the string. You instead reference the already existing string.