使用laravel命令类运行bash脚本，找不到错误

Question

我想使用laravel命令类运行简单的bash脚本，但是我没有发现错误。 如果我转到/var/www/mysite/storage/app/scripts，然后从命令行中运行脚本，那么一切都可以。

$ sh remove-spaces.sh

我的Laravel代码有什么问题？

lowercase.sh

for file in /var/www/mysite/storage/app/img/*; 
do mv "$file" "`echo $file | tr '[A-Z]' '[a-z]'`"; 
done

删除空间.sh

for file in /var/www/mysite/storage/app/img/*; 
do mv "$file" `echo $file | tr ' ' '-'`; 
done

renamePicturesCommand

namespace App\Console\Commands\Pictures;
use Illuminate\Console\Command;
use Symfony\Component\Process\Process;
use Symfony\Component\Process\Exception\ProcessFailedException;

class RenamePicturesCommand extends Command
{
    protected $removeSpaces;
    protected $lowercase;
    protected $signature = 'pictures:rename';

    public function __construct()
    {
        parent::__construct();
        $this->removeSpaces = new Process(['sh /var/www/mysite/storage/app/scripts/remove-spaces.sh']);
        $this->lowercase = new Process(['sh /var/www/mysite/storage/app/scripts/lowercase.sh']);
    }


    public function handle()
    {
        $this->removeSpaces->run();
        if (!$this->removeSpaces->isSuccessful()) {
            throw new ProcessFailedException($this->removeSpaces);
        }
        echo $this->removeSpaces->getOutput();

        $this->lowercase->run();
        if (!$this->lowercase->isSuccessful()) {
            throw new ProcessFailedException($this->lowercase);
        }
        echo $this->lowercase->getOutput();
    }
}

错误输出

http@0bb690b74597:/var/www/mysite$ php artisan pictures:rename

   Symfony\Component\Process\Exception\ProcessFailedException

  The command "'sh /var/www/mysite/storage/app/scripts/remove-spaces.sh'" failed.

Exit Code: 127(Command not found)

Working directory: /var/www/mysite

Output:
================


Error Output:
================
sh: 1: exec: sh /var/www/mysite/storage/app/scripts/remove-spaces.sh: not found

  at app/Console/Commands/Pictures/RenamePicturesCommand.php:59
     55▕         // execute command
     56▕         $this->removeSpaces->run();
     57▕         // executes after the command finishes
     58▕         if (!$this->removeSpaces->isSuccessful()) {
  ➜  59▕             throw new ProcessFailedException($this->removeSpaces);
     60▕         }
     61▕         echo $this->removeSpaces->getOutput();
     62▕
     63▕

      +13 vendor frames
  14  artisan:37
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Answer 1

您可以尝试将命令和参数作为命令数组中的两个单独的项目提供，

namespace App\Console\Commands\Pictures;
use Illuminate\Console\Command;
use Symfony\Component\Process\Process;
use Symfony\Component\Process\Exception\ProcessFailedException;

class RenamePicturesCommand extends Command
{
    protected $removeSpaces;
    protected $lowercase;
    protected $signature = 'pictures:rename';

    public function __construct()
    {
        parent::__construct();
        $this->removeSpaces = new Process(['sh', '/var/www/mysite/storage/app/scripts/remove-spaces.sh']);
        $this->lowercase = new Process(['sh', '/var/www/mysite/storage/app/scripts/lowercase.sh']);

        //Or you can use Process::fromShellCommandline
        //$this->removeSpaces =Process::fromShellCommandline('sh /Volumes/samsung-250/Sites/stackoverflow/storage/app/scripts/lowercase.sh');
        //$this->lowercase =Process::fromShellCommandline('sh /Volumes/samsung-250/Sites/stackoverflow/storage/app/scripts/remove-spaces.sh');
    }


    public function handle()
    {
        $this->removeSpaces->run();
        if (!$this->removeSpaces->isSuccessful()) {
            throw new ProcessFailedException($this->removeSpaces);
        }
        echo $this->removeSpaces->getOutput();

        $this->lowercase->run();
        if (!$this->lowercase->isSuccessful()) {
            throw new ProcessFailedException($this->lowercase);
        }
        echo $this->lowercase->getOutput();
    }
}

您也可以使用存储幕墙实现相同的结果，而无需任何shell脚本

namespace App\Console\Commands\Pictures;

use Illuminate\Console\Command;
use Illuminate\Support\LazyCollection;

class RenamePicturesCommand extends Command
{
    protected $signature = 'pictures:rename';


    public function handle()
    {
        $this->info('Renaming pictures...');
        $this->newLine(2);

        $files = LazyCollection::make(Storage::disk('local')->files('img'))
            //Remove dotfiles
            ->reject(fn($filePath) => Str::startsWith($filePath, '.'));

        $progress = $this->output->createProgressBar($files->count());
        $progress->start();

        $modified = [];

        $files->each(function ($file) use ($progress, &$modified) {

            $new = strtolower(preg_replace('/\s+/', '-', $file));

            $temp = ['old' => $file, 'new' => $new, 'status' => 'success'];

            if(! Storage::disk('local')->move($file, $new)) {
                $temp['status'] = 'failed';
                $temp['new'] = $file;
            }

            $modified[] = $temp;

            $progress->advance();
        });

        
        $this->newLine(2);
        $this->info('Finished Renaming pictures');
        $this->newLine(2);
        $this->table(['Old', 'New', 'Status'], $modified);
    }
}