如何重构/简化以下PHP功能？

Question

我的功能可以返回发票上有多少个产品，对我来说似乎很简单，但是也许可以使用一些重构？

    public function getTotalProductsNumber(): int
{
    $dataset = 'supplier_invoice_products inner join supplier_invoices as si using (supplier_invoice_id)';
    $dbmSupplier = new Dbm_Supplier($dataset);

    $whereAndOpt = $this->getConditionsAndOptions();
    $where = $whereAndOpt['where'];
    $opt = $whereAndOpt['opt'];
    $select = 'sum(product_quantity) as sumTotal';
    $invoiceTotalProductsNumber =  $dbmSupplier->findFirstSimple($where, $select, $opt);
    $invoiceTotalProductsNumber['sumTotal'] = (int)$invoiceTotalProductsNumber['sumTotal'];
    return $invoiceTotalProductsNumber['sumTotal'];
}

如何将其提取到至少两个功能中？

Answer 1

对于这种事情，理想情况下，您会使用ORM。由于我不确定您正在使用哪个，如果有的话，我可能会在这个方向上重新分配一些东西，以便更接近一个ORM的工作方式：

public function getTotalProductsNumber(): int
{
    $dataset = 'supplier_invoice_products inner join supplier_invoices as si using (supplier_invoice_id)';
    $extras = $this->getConditionsAndOptions();
    $queryBuilder = [
        'dbm' => new Dbm_Supplier($dataset),
        'where' =>  $extras['where'],
        'opt' => $extras['opt']
    ];
    return $this->sumOfProductQuantities($queryBuilder);
}

private function sumOfProductQuantities(array $queryBuilder): int
{
    $select = 'sum(product_quantity) as sumTotal';
    $row = $this->queryBuilderFirstRow($queryBuilder, $select);
    return (int)$row['sumTotal'];
}

private function queryBuilderFirstRow(array $qb, string $select): array
{
    return $qb['dbm']->findFirstSimple($qb['where'], $select, $qb['opt']);
}

Answer 2

我个人认为这非常简单明了，但是我建议的唯一优化是提取getConditionsandOptions部分，因为它似乎在代码的其他几个部分中使用。请看一下：

public function getTotalProductsNumber(): int
{
    $dataset = 'supplier_invoice_products inner join supplier_invoices as si using (supplier_invoice_id)';
    $dbmSupplier = new Dbm_Supplier($dataset);

    list($where, $opt) = $this->getWhereAndOpt();

    $select = 'sum(product_quantity) as sumTotal';
    $invoiceTotalProductsNumber = $dbmSupplier->findFirstSimple($where, $select, $opt);
    $invoiceTotalProductsNumber['sumTotal'] = (int)$invoiceTotalProductsNumber['sumTotal'];
    return $invoiceTotalProductsNumber['sumTotal'];
}

private function getWhereAndOpt(): array
{
    $whereAndOpt = $this->getConditionsAndOptions();
    return [
        $whereAndOpt['where'],
        $whereAndOpt['opt'],
    ];
}

另一点也许是命名约定。我可以看到您已经使用了Snail_case dbm_supplier的命名。最好是dbm_supplier或dbmsupplier。