尝试使用一个类（自行车）中的方法在我的第二类（DockingStation）中实现

Question

   class DockingStation
  
  attr_reader :bikes, :capacity
  attr_accessor :capacity
  
  DEFAULT_CAPACITY = 20
  
 def initialize(capacity = DEFAULT_CAPACITY)
   @bikes = []  
   @capacity = capacity
 end
 

 
  def release_bike
    fail 'No bikes available' if empty?
    @bikes
  end
  
  def dock(bike)
    fail 'bike full' if full?
    @bikes << bike
  end
  
  def full?
    @bikes.count >= DEFAULT_CAPACITY
  end
  
  def empty?
    @bikes.empty?
  end
  

  private :full? , :empty? 
  
end
 class Bike
    def working?
        true
      end
      def report_broken
         @broken = true
      end
      def broken?
        @broken
      end
    end
    require './lib/docking_station.rb'
    require './lib/bike.rb'
    describe DockingStation  do
        describe 'initialization' do
            subject{DockingStation.new}
            let(:bike) {Bike.new}
            it 'default capacity' do 
                described_class::DEFAULT_CAPACITY.times do
                    subject.dock(bike) 
                end
                expect{ subject.dock(bike) }.to raise_error 'bike full'
             end
        end    
        it 'has a default capacity' do
        expect(subject.capacity).to eq DockingStation::DEFAULT_CAPACITY
      end
         describe '#release_bike' do
            it 'releases a bike' do
                 bike = Bike.new

我希望我的RSPEC测试通过（下方），但我一直遇到任何没有提出的错误。我的目标是让我的车站不释放停靠时报告的破损自行车，但是方法破了？是否在我的自行车文件中，所以我无法用我的方法写“失败的“自行车损坏”，如果损坏了？由于对接站文件无法识别该方法。在正确方向上的任何帮助都非常感谢

it 'raises an error if bike is broken' do
           bike = Bike.new
           bike.report_broken
           subject.dock bike
           expect {subject.release_bike}.to raise_error 'No bikes available'
        end
    

Answer 1

如果停靠站没有自行车或仅损坏的自行车，您的测试看起来会引起错误。

it 'raises an error if bike is broken' do
  bike = Bike.new
  bike.report_broken
  subject.dock bike
  expect {subject.release_bike}.to raise_error 'No bikes available'
end

但是您的Release_bike当前没有考虑到损坏的自行车：

def release_bike
  fail 'No bikes available' if empty?
  @bikes
end

我想如果将该方法更改为以下方法，则您的测试应通过：

def release_bike
  available_bikes = @bikes.select { |bike| !bike.broken? }
  fail 'No bikes available' if available_bikes.empty?
  available_bikes
end

哪个首先从@bikes 不损坏的数组，然后仅检查是否有不间断的自行车。