将字符串拆分为唯一列表 - 重构它

发布于 2024-12-31 22:49:51 字数 559 浏览 4 评论 0原文

好吧，这看起来很难看:) 重构这段代码的好方法是什么？

Users 是在屏幕上输入的数据，对于此示例，我们希望在 _someDTOObject.Users 中得到不同的结果

string[] userNames = Users.Split(new char[] { ',' });
string tempUserStr = "";
foreach (string user in userNames)
{
    tempUserStr += user.Trim().ToUpper() + ",";
}

userNames = tempUserStr.Split(new char[] { ',' });
var uniqueUsers = userNames.Distinct().ToList();

foreach (string user in uniqueUsers)
{
    if (!string.IsNullOrEmpty(user))
    {
        _someDTOObject.Users += user + ",";
    }   
}

原文

Ok, this looks ugly :) What is a good way to refactor this block of code?

Users is data which is entered on the screen, and for this example we want distinct result in the _someDTOObject.Users

string[] userNames = Users.Split(new char[] { ',' });
string tempUserStr = "";
foreach (string user in userNames)
{
    tempUserStr += user.Trim().ToUpper() + ",";
}

userNames = tempUserStr.Split(new char[] { ',' });
var uniqueUsers = userNames.Distinct().ToList();

foreach (string user in uniqueUsers)
{
    if (!string.IsNullOrEmpty(user))
    {
        _someDTOObject.Users += user + ",";
    }   
}

分享到QQ

分享到微博

如果你对这篇内容有疑问，欢迎到本站社区发帖提问参与讨论，获取更多帮助，或者扫码二维码加入 Web 技术交流群。

发布评论

需要登录才能够评论，你可以免费注册一个本站的账号。

紫轩蝶泪 2025-01-07 22:49:51

它看起来就像你可能想要这样的东西：

_someDTOObject.Users = string.Join(",", Users.Split(',')
                                             .Select(x => x.Trim().ToUpper())
                                             .Distinct());

...但我不清楚为什么你要通过 split/join/split 开始...

注意：如果你使用 . NET 3.5 中，您需要在 Distinct 之后进行额外的 ToArray 调用。在 .NET 4 上则不需要，因为 string.Join 重载集已增加。

（正如 StriplingWarrior 的回答所述，这不会有尾随逗号。您想要尾随逗号吗？）

It looks like you probably want something like:

_someDTOObject.Users = string.Join(",", Users.Split(',')
                                             .Select(x => x.Trim().ToUpper())
                                             .Distinct());

... but it's not clear to me why you're going through split/join/split to start with...

Note: if you're using .NET 3.5, you'll need an extra ToArray call after Distinct. You don't on .NET 4, as the set of string.Join overloads has been increased.

(As noted in StriplingWarrior's answer, this won't have a trailing comma. Did you want a trailing comma?)

回复收藏 0 原文

源来凯始玺欢你 2025-01-07 22:49:51

这是一种更简洁的方式，可以大部分获得相同的结果：

var distinctUsers = 
    (from user in Users.Split(new[]{','})
     select trimmedUpper = user.Trim().ToUpper())
    .Distinct()

_someDTOObject.Users = string.Join(",", distinctUsers);

但是，这不会有结尾的“，”，这可能是理想的，也可能不是。您可能还想检查一下为什么需要首先以逗号分隔的列表结尾。您是否最好传递用户名列表？

This is a much cleaner way to mostly get the same result:

var distinctUsers = 
    (from user in Users.Split(new[]{','})
     select trimmedUpper = user.Trim().ToUpper())
    .Distinct()

_someDTOObject.Users = string.Join(",", distinctUsers);

However, this won't have a trailing ",", which may or may not be desirable. You may also want to examine why you need to end up with a comma-separated list in the first place. Is it possible that you'd be better off passing around a list of user names instead?

回复收藏 0 原文

星軌x 2025-01-07 22:49:51

这将负责删除重复的名称和空的名称。

string Users = "bob, bill, james, frank, , bill"; 
var z = Users.Split( new char[] {','}, StringSplitOptions.RemoveEmptyEntries).Select(x=> x.Trim().ToUpper()).Distinct().ToArray();  
var result = string.Join(",", z);

This will take care of removing duplicated and empty names.

string Users = "bob, bill, james, frank, , bill"; 
var z = Users.Split( new char[] {','}, StringSplitOptions.RemoveEmptyEntries).Select(x=> x.Trim().ToUpper()).Distinct().ToArray();  
var result = string.Join(",", z);

回复收藏 0 原文

风柔一江水 2025-01-07 22:49:51

我希望这会有用。

_someDTOObject.Users = Users.Split(new char[] { ',' }, StringSplitOptions.RemoveEmptyEntries).Select(user => user.Trim().ToUpper()).Distinct().Aggregate((users, user) => users + "," + user);

问候。

I hope this can be useful.

_someDTOObject.Users = Users.Split(new char[] { ',' }, StringSplitOptions.RemoveEmptyEntries).Select(user => user.Trim().ToUpper()).Distinct().Aggregate((users, user) => users + "," + user);

Regards.

回复收藏 0 原文

~没有更多了~