如何将两种方法转换为一种方法以提高效率？

Question

如何将两个方法转换为一个方法以提高效率并使代码清晰简洁？

我还有三个这样的条件要检查，但我没有提到（太长了）：

 public void getmembershipstatusmembers()
 {
        if (cbGEStatustype.Text != "")
        {
            var totalmembers = from tsgentity in eclipse.members
                               join memtomships in eclipse.membertomships on tsgentity.member_Id equals memtomships.member_Id
                               join mshipoptiions in eclipse.mshipoptions on memtomships.mshipOption_Id equals mshipoptiions.mshipOption_Id
                               join mshiptypes in eclipse.mshiptypes on mshipoptiions.mshipType_Id equals mshiptypes.mshipType_Id
                               join mshipstatus in eclipse.mshipstatustypes on memtomships.mshipStatusType_Id equals mshipstatus.mshipStatusType_Id
                               where mshipstatus.mshipStatusType_Name.StartsWith(cbGEStatustype.Text)
                               select new
                               {
                                   tsgentity.member_Id,
                                   tsgentity.member_Lastname,
                                   tsgentity.member_Firstname,
                                   tsgentity.member_Postcode,
                                   tsgentity.member_Reference,
                                   tsgentity.member_CardNum,
                                   tsgentity.member_IsBiometric,
                                   tsgentity.member_Dob,
                                   mshiptypes.mshipType_Name,
                                   mshipstatus.mshipStatusType_Name,
                                   memtomships.memberToMship_EndDate
                               };
            dgvReportMembers.DataSource = totalmembers;       
        }
    }
    public void getcardnumbers()
    {
        if (txtcardnum.Text != "")
        {
            var totalmembers = from tsgentity in eclipse.members
                               join memtomships in eclipse.membertomships on tsgentity.member_Id equals memtomships.member_Id
                               join mshipoptiions in eclipse.mshipoptions on memtomships.mshipOption_Id equals mshipoptiions.mshipOption_Id
                               join mshiptypes in eclipse.mshiptypes on mshipoptiions.mshipType_Id equals mshiptypes.mshipType_Id
                               join mshipstatus in eclipse.mshipstatustypes on memtomships.mshipStatusType_Id equals mshipstatus.mshipStatusType_Id
                               where tsgentity.member_CardNum.StartsWith(txtcardnum.Text)
                               select new
                               {
                                   tsgentity.member_Id,
                                   tsgentity.member_Lastname,
                                   tsgentity.member_Firstname,
                                   tsgentity.member_Postcode,
                                   tsgentity.member_Reference,
                                   tsgentity.member_CardNum,
                                   tsgentity.member_IsBiometric,
                                   tsgentity.member_Dob,
                                   mshiptypes.mshipType_Name,
                                   mshipstatus.mshipStatusType_Name,
                                   memtomships.memberToMship_EndDate
                               };
            dgvReportMembers.DataSource = totalmembers;
        }

    }

我正在寻找这样的东西：

 private void allmembers()
 {
       var members = from ......
                          .......
                          .......
        if (cbGEStatustype.Text != "")
        {
           dgvreports.datasource = members.where(.......)
         }
         if (txtcardnum.Text != "")
         {    
             dgvreports.datasource = members.where(.......)
         }
    }

Answer 1

你找错了树。让一种方法完成其他两种方法的工作有时是一个好主意，但永远不会使您的代码显着提高（或降低）效率。

建议的更改会让您的代码更加清晰吗？这是值得做的。会减少重复吗？这也是值得做的。这是正确的改变吗？查看您的代码，我猜想更好的方法是将方法的公共部分提取到新方法中，并从现有方法中调用该新方法。

Answer 2

如果我正确地阅读了这篇文章，我认为您可以创建您的方法，以便不直接将数据源设置为查询结果，而是将结果作为 IQueryable 对象返回，以便您可以应用尽可能多的后续过滤器你需要。我认为困难可能在于您的两个方法似乎使用匿名类型，该类型在方法之间无法通信，但您可以创建一个简单的类型定义来填补空白。

例如

public class Foo {
public string MemberID { get; set;}
public string LastName { get; set;}
// ... etc.
} 

public IQueryably<Foo> GetUnfiltereredSource()
{
    // NOTE: No WHERE here...
    return 
        from tsgentity in eclipse.members 
        join memtomships in eclipse.membertomships on tsgentity.member_Id equals memtomships.member_Id 
        join mshipoptiions in eclipse.mshipoptions on memtomships.mshipOption_Id equals mshipoptiions.mshipOption_Id 
        join mshiptypes in eclipse.mshiptypes on mshipoptiions.mshipType_Id equals mshiptypes.mshipType_Id 
        join mshipstatus in eclipse.mshipstatustypes on memtomships.mshipStatusType_Id equals mshipstatus.mshipStatusType_Id 
        select new Foo
        { 
           MemberID =  tsgentity.member_Id, 
           LastName = tsgentity.member_Lastname, 
           // ... etc.
        }; 
}

public void DoStuff()
{
    dgvreports.datasource = GetUnfilteredSource().Where(x => x.MemberCardNumber.StartsWith(...));

    // OR

    dgvreports.datasource = GetUnfilteredSource().Where(x => x.MemberShipStatusType.StartsWith(...));

    // etc..
}