通过java Socket传输错误的文件

Question

今天下午我写了这个类，其目的是提供一种通过 TCP 套接字交换发送文件的简单方法。
问题是，尽管最终文件大小是正确的，但内容是错误的：目标文件恰恰是由通过 Socket 发送的第一个缓冲区的各个副本组成的。 我的类很简单：它根据缓冲区大小计算 Q 和 R，并将该数字与原始文件名一起发送给客户端。我使用字节数组通过套接字发送数据。

package it.s4sytems.java;  
import java.io.*;  
import java.net.*;  

public class FileOverObjectStream
{
    private File file;
    private int bufferSize = 4*1024*1024; //4MB default, comunque è stabilito dal sender

    private static class Info implements Serializable
    {
        public String fileName;
        public long q;
        public int r;
        public int bufferSize;
    }

    public FileOverObjectStream(File file)
    {
        this.file = file;
    }

    public FileOverObjectStream(File file, int bufferSize)
    {
        this(file);
        this.bufferSize = bufferSize;
    }

    public void sendFile(Socket socket) throws IOException
    {
        socket.getInputStream();
        sendFile( socket.getOutputStream() );
    }

    public void sendFile(OutputStream outStream)throws IOException
    {
        sendFile( new ObjectOutputStream(outStream) );
    }

    public void sendFile(ObjectOutputStream objOutStream) throws IOException
    {
        BufferedInputStream in = new BufferedInputStream( new FileInputStream(file) );
        byte[] buffer = new byte[bufferSize];

        Info info = new Info();
            info.fileName = file.getName();
            info.bufferSize = bufferSize;
            info.q = file.length() / bufferSize;
            info.r = (int) file.length() % bufferSize;
        objOutStream.writeObject(info);

        for(long i=0; i<info.q; i++)
        {
            in.read(buffer);
            objOutStream.writeObject(buffer);
            objOutStream.flush();
        }
        in.read( buffer = new byte[info.r]);
        objOutStream.writeObject(buffer);

        objOutStream.flush();
        in.close();
    }

    public String receiveFile(Socket socket) throws IOException, ClassNotFoundException
    {
        socket.getOutputStream();
        return receiveFile( socket.getInputStream() );
    }

    public String receiveFile(InputStream inStream) throws IOException, ClassNotFoundException
    {
        return receiveFile( new ObjectInputStream(inStream) );
    }

    public String receiveFile(ObjectInputStream objInStream) throws IOException, ClassNotFoundException
    {
        BufferedOutputStream out = new BufferedOutputStream( new FileOutputStream(file) );

        Info info = (Info) objInStream.readObject();
        for(long i=0; i<info.q+1; i++)
        {
            byte[] buffer = (byte[]) objInStream.readObject();
            out.write( buffer );
        }

        out.close();
        return info.fileName;
    }
}

我创建了两个类来进行一些尝试...

import it.s4sytems.java.*;
import java.io.*;
import java.net.ServerSocket;
import java.net.Socket;

public class Server
{
    public static void main(String arg[]) throws IOException
    {
        ServerSocket ss = new ServerSocket(18000);

        while(true)
        {
            Socket s = ss.accept();

            File file = new File("G:\\HCHCK_72_5.38.part04.rar");
            FileOverObjectStream sender = new FileOverObjectStream(file);
            sender.sendFile(s);
            s.close();
        }
    }
}

和客户...

import it.s4sytems.java.*;
import java.io.*;
import java.net.*;

public class Client
{
    public static void main(String arg[]) throws IOException, ClassNotFoundException
    {
        Socket s = new Socket("localhost", 18000);

        String matricola = "616002424";

        File directory = new File(System.getProperty("user.dir") + "\\" + matricola);
        directory.mkdir();

        File file = File.createTempFile("7897_", null, directory);

        String originalName = new FileOverObjectStream(file).receiveFile(s);

        System.out.println(originalName);

        s.close();


        File file2 = new File(directory, originalName);
        System.out.println( file.renameTo( file2 ) );
        System.out.println( file.getAbsoluteFile());
        System.out.println( file2.getAbsoluteFile());
    }
}

可能这是一件愚蠢的事情，但我看不到它，所以我需要你的帮助。

谢谢

Answer 1

我认为 ObjectOutputStream 不适合您的用例。除非我错过了什么。一般来说，尝试使用一些好的 IO 库，例如 Apache Commons IO。它的方法总是能做正确的事情。例如，查看 IOUtils 。

---

需要强调的一些错误（好的库不会发生这些错误）

• in.read(buffer) 不保证读取确切的字节数。您必须检查其结果并只写出正确的数字。
• 您可以使用writeObject将缓冲区对象写入ObjectOutputStream。这写入序列化字节缓冲区而不是原始字节序列。

Answer 2

您的 ObjectInput/OutputStream 代码在 Alex 指出的所有方面都存在缺陷。我根本不会使用它，我只会使用原始 I/O。在 Java 中复制流的规范方法如下：

int count;
byte[] buffer = new byte[8192]; // or more, but megabytes is pointless as the network will packetize anyway
while ((count = in.read(buffer)) > 0)
{
  out.write(buffer, 0, count);
}

发送和接收文件时使用相同的代码。如果您想发送>每个连接 1 个文件，您需要通过发送文件名和长度来为所有文件添加前缀，您可以使用 DataOutputStream.writeUTF()/writeLong() 和 DataInputStream.readUTF() 来完成此操作/readLong() 在接收器处，并修改循环控制以准确读取那么多字节：

long remaining = size; // the file size read from the network
while ((count = in.read(buffer, 0, remaining > buffer.length ? buffer.length : (int)remaining)) > 0)
{
    out.write(buffer, 0, count);
    remaining -= count;
}