fwrite 不写入整个缓冲区

发布于 2024-11-03 04:49:46 字数 3510 浏览 1 评论 0原文

我目前正在制作一个用于简单文件检查的小测试程序。该程序将两个小矩阵(A 和 B)写入文件,关闭并重新打开它们,从文件中读取矩阵,将它们相乘并将结果矩阵(C)写入新文件。然后它关闭并重新打开包含答案的文件,并将其打印出来供我检查 IO 操作是否正确进行。

我的问题是结果矩阵的读数与预期不同。

我认为自己是 C 和文件输入/输出操作的初学者,这就是给我带来麻烦的代码。我正在使用 WinXP、Codeblocks 和 Mingw。

#include <stdio.h>
#include <stdlib.h>
#include <math.h>

#define bufferA(i,k) (bufferA[i*cols+k])
#define bufferB(k,j) (bufferB[k*cols+j])
#define bufferC(i,j) (bufferC[i*cols+j])

void printMatrix(int *nMatrixToPrint, int nNumberOfElements, int nDimension) {
// This function prints out the element of an Array. This array represents a matrix in memory.

int nIndex;
printf("\n");

for (nIndex = 0; nIndex < nNumberOfElements; nIndex++) {
    if (nIndex % nDimension == 0)
        printf("\n");
    printf("%d,",nMatrixToPrint[nIndex]);
    }

return;
}

int main(int argc, char *argv[]) {
int nElements = 16, nDim = 4;
int A[4][4] = {{1,2,3,1},{2,2,1,2},{4,2,3,1},{5,1,1,3}};
int B[4][4] = {{3,2,1,4},{2,2,3,3},{4,1,3,2},{2,2,5,1}};

// Create files of A and B, delete old ones if present
FILE *fpA = fopen("A.dat", "w+");
FILE *fpB = fopen("B.dat", "w+");

// Write data to them
fwrite((int*)A, sizeof(*A), nElements, fpA);
fwrite((int*)B, sizeof(*B), nElements, fpB);

// and close them
fclose(fpA);
fclose(fpB);

// Reopen files
fpA = fopen("A.dat", "r");
fpB = fopen("B.dat", "r");

// Allocate memory
int *bufferA = (int*)malloc(nElements * sizeof(*bufferA));
int *bufferB = (int*)malloc(nElements * sizeof(*bufferB));
int *bufferC = (int*)calloc(nElements, sizeof(*bufferC));

// Read files
fread(bufferA, sizeof(int), nElements, fpA);
fread(bufferB, sizeof(int), nElements, fpB);

printf("\nA");
printMatrix(bufferA, nElements, nDim);
printf("\n\nB");
printMatrix(bufferB, nElements, nDim);

// Matrix multiplication
// Calculate and write to C
int i,j,k = 0; // Loop indices
int n = nDim,l = nDim, m = nDim, cols = nDim;

// multiply
for (i = 0; i < n; i++) {           // Columns
    for (j = 0; j < m; j++) {       // Rows
        //C(i,j) = 0;
        for (k = 0; k < l; k++) {
            bufferC(i,j) += bufferA(i,k) * bufferB(k,j);
        }
    }
}
printf("\n\nC_buffer");
printMatrix(bufferC, nElements, nDim);

// Create C and write to it
FILE* Cfile = fopen("C.dat", "w");
fwrite(bufferC, sizeof(*bufferC), nElements, Cfile);

// Close files
fclose(fpA);
fclose(fpB);
fclose(Cfile);

// reopen C for reading
Cfile = fopen("C.dat", "r");

// Obtain file size
fseek(Cfile , 0 , SEEK_END);
long lSize = ftell(Cfile);
rewind(Cfile);
printf("\nC file length is: %ld", lSize);

// read data into bufferA
fread(bufferA, sizeof(int), lSize, Cfile);
fclose(Cfile);

printf("\n\nC_file");
printMatrix(bufferA, nElements, nDim);

// Free allocated memory and remove dangling pointers
free(bufferA); bufferA = NULL;
free(bufferB); bufferB = NULL;
free(bufferC); bufferC = NULL;

exit(0);
}

这给了我以下输出:

A

1,2,3,1,
2,2,1,2,
4,2,3,1,
5,1,1,3,

B

3,2,1,4,
2,2,3,3,
4,1,3,2,
2,2,5,1,

C_buffer

21,11,21,17,
18,13,21,18,
30,17,24,29,
27,19,26,28,
C文件长度为:64

C_file

21,11,21,17,
18,13,21,18,
30,17,24,29,
27,19,1,3,

如您所见,C_file 中的最后两个元素是错误的,相反,当我将文件内容写入 bufferA 时,输出显示 A 中的最后两个元素。切换到 bufferB 会将最后两个字符与 B 中的最后一个元素交换,这仍然是错误的。将文件复制到另一个项目将产生最后两个整数,就像该 malloc 地址的 ram 中的内容一样。

我的问题如下:为什么 fwrite 不将正确的数据写入文件中。为什么它管理前 14 个元素而不管理后两个?这与我之前在写入和检索 A 和 B 的元素时正确使用 fwrite 和 fread 有何不同?

I am currently making a small test program for simple file checking. The program writes two small matrices(A and B) to files, closes and reopens them, reads in the matrices from the files, multiplies them and writes the resulting matrix(C) to a new file. It then closes and reopens this file containing the answer and prints it out for me to check if the IO operation proceeded correctly.

My problem is that the result matrix reads differently than expected.

I consider myself a beginner in C and of file input/output operations and this is the code that is causing me trouble. I am using WinXP, Codeblocks and Mingw.

#include <stdio.h>
#include <stdlib.h>
#include <math.h>

#define bufferA(i,k) (bufferA[i*cols+k])
#define bufferB(k,j) (bufferB[k*cols+j])
#define bufferC(i,j) (bufferC[i*cols+j])

void printMatrix(int *nMatrixToPrint, int nNumberOfElements, int nDimension) {
// This function prints out the element of an Array. This array represents a matrix in memory.

int nIndex;
printf("\n");

for (nIndex = 0; nIndex < nNumberOfElements; nIndex++) {
    if (nIndex % nDimension == 0)
        printf("\n");
    printf("%d,",nMatrixToPrint[nIndex]);
    }

return;
}

int main(int argc, char *argv[]) {
int nElements = 16, nDim = 4;
int A[4][4] = {{1,2,3,1},{2,2,1,2},{4,2,3,1},{5,1,1,3}};
int B[4][4] = {{3,2,1,4},{2,2,3,3},{4,1,3,2},{2,2,5,1}};

// Create files of A and B, delete old ones if present
FILE *fpA = fopen("A.dat", "w+");
FILE *fpB = fopen("B.dat", "w+");

// Write data to them
fwrite((int*)A, sizeof(*A), nElements, fpA);
fwrite((int*)B, sizeof(*B), nElements, fpB);

// and close them
fclose(fpA);
fclose(fpB);

// Reopen files
fpA = fopen("A.dat", "r");
fpB = fopen("B.dat", "r");

// Allocate memory
int *bufferA = (int*)malloc(nElements * sizeof(*bufferA));
int *bufferB = (int*)malloc(nElements * sizeof(*bufferB));
int *bufferC = (int*)calloc(nElements, sizeof(*bufferC));

// Read files
fread(bufferA, sizeof(int), nElements, fpA);
fread(bufferB, sizeof(int), nElements, fpB);

printf("\nA");
printMatrix(bufferA, nElements, nDim);
printf("\n\nB");
printMatrix(bufferB, nElements, nDim);

// Matrix multiplication
// Calculate and write to C
int i,j,k = 0; // Loop indices
int n = nDim,l = nDim, m = nDim, cols = nDim;

// multiply
for (i = 0; i < n; i++) {           // Columns
    for (j = 0; j < m; j++) {       // Rows
        //C(i,j) = 0;
        for (k = 0; k < l; k++) {
            bufferC(i,j) += bufferA(i,k) * bufferB(k,j);
        }
    }
}
printf("\n\nC_buffer");
printMatrix(bufferC, nElements, nDim);

// Create C and write to it
FILE* Cfile = fopen("C.dat", "w");
fwrite(bufferC, sizeof(*bufferC), nElements, Cfile);

// Close files
fclose(fpA);
fclose(fpB);
fclose(Cfile);

// reopen C for reading
Cfile = fopen("C.dat", "r");

// Obtain file size
fseek(Cfile , 0 , SEEK_END);
long lSize = ftell(Cfile);
rewind(Cfile);
printf("\nC file length is: %ld", lSize);

// read data into bufferA
fread(bufferA, sizeof(int), lSize, Cfile);
fclose(Cfile);

printf("\n\nC_file");
printMatrix(bufferA, nElements, nDim);

// Free allocated memory and remove dangling pointers
free(bufferA); bufferA = NULL;
free(bufferB); bufferB = NULL;
free(bufferC); bufferC = NULL;

exit(0);
}

Which gives me the following output:

A

1,2,3,1,
2,2,1,2,
4,2,3,1,
5,1,1,3,

B

3,2,1,4,
2,2,3,3,
4,1,3,2,
2,2,5,1,

C_buffer

21,11,21,17,
18,13,21,18,
30,17,24,29,
27,19,26,28,
C file length is: 64

C_file

21,11,21,17,
18,13,21,18,
30,17,24,29,
27,19,1,3,

As you can see, the last two elements in C_file are wrong, instead the output shows the last two elements in A as I was writing the file contents into bufferA. A switch to bufferB would swap the last two characters with the last elements in B which is still erroneous. A filecopy into another project would yield the last two integers as whatever was in ram at that malloc address.

My question is as follows: Why does not fwrite write the proper data into the file. Why does it manage the first 14 elements but not the last two? And how does this differ from my previous correct uses of fwrite and fread when I wrote and retrieved the elements of A and B?

如果你对这篇内容有疑问,欢迎到本站社区发帖提问 参与讨论,获取更多帮助,或者扫码二维码加入 Web 技术交流群。

扫码二维码加入Web技术交流群

发布评论

需要 登录 才能够评论, 你可以免费 注册 一个本站的账号。

评论(2

似狗非友 2024-11-10 04:49:46

您正在写入二进制数据,因此您必须以二进制模式打开文件,默认为文本模式。这在 Windows 上有所不同,但在 *nix 上则不然,这解释了为什么它对这里的其他人有效。

对于所有 fopen 调用,请包含模式参数中的字母“b”,例如将“w+”替换为“w+b”,将“r”替换为“rb”等等。

You are writing binary data, and therefore you have to open the file in binary mode, the default is text mode. This makes a difference on windows, but not on *nix, which explains why it works for the other people here.

for all your fopen calls, include the letter 'b' in the mode argument, e.g. replace "w+" with "w+b" , replace "r" with "rb" and so on.

眼泪都笑了 2024-11-10 04:49:46

你的程序在我的 Mac 上运行得很好。

如果 printMatrix() 输出最后的换行符,结果看起来会更好。也许未终止的线路正在对您的系统造成某种混乱?

Your program runs just fine on my Mac.

The results would look better if printMatrix() output a final newline. Perhaps the unterminated line is causing some sort of confusion on your system?

~没有更多了~
我们使用 Cookies 和其他技术来定制您的体验包括您的登录状态等。通过阅读我们的 隐私政策 了解更多相关信息。 单击 接受 或继续使用网站,即表示您同意使用 Cookies 和您的相关数据。
原文