ABRecordCopyValue 潜在的内存泄漏

Question

我正在构建一个应用程序，要求我从 iPhone 地址簿加载表数据源中的所有联系人。跑步时

构建和分析

以下代码片段，

ABAddressBookRef addressBook = ABAddressBookCreate(); 
int nPeople = ABAddressBookGetPersonCount(addressBook); 
CFRelease(addressBook);

for(int i=0; i < nPeople; i++ ){
    //ABRecordRef person = [allPeople objectAtIndex:i];
    NSString *name = @"";
    if(ABRecordCopyValue([allPeople objectAtIndex:i], kABPersonFirstNameProperty) != NULL)
        name = [[NSString stringWithFormat:@"%@", ABRecordCopyValue([allPeople objectAtIndex:i], kABPersonFirstNameProperty)] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]];
    [dataSource addObject: name];
}

[allPeople release];

我发现该行存在潜在的内存泄漏，

name = [[NSString stringWithFormat:@"%@", ABRecordCopyValue([allPeople objectAtIndex:i], kABPersonFirstNameProperty)] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]];

我真的厌倦了修复它，但无法修复。请帮助我。

任何形式的帮助将不胜感激。

提前致谢！！

Answer 1

您没有发布 ABRecordCopyValue 的结果；尝试将其分配给一个变量并释放它并结束循环。使用变量还将使您的代码更易于阅读并更好地突出这些问题的原因。

顺便说一句，您还使用相同的参数调用 ABRecordCopyValue 两次，您应该只执行一次（使用如上所述的变量）。

Answer 2

我认为你可以这样做：

CFTypeRef copiedValue = ABRecordCopyValue([allPeople objectAtIndex:i], kABPersonFirstNameProperty);
name = [[NSString stringWithFormat:@"%@", copiedValue] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]];
CFRelease(copiedValue);

Answer 3

您可以直接桥接到 NSString。可能更清楚一点：

CFTypeRef fn_typeref = ABRecordCopyValue(person, kABPersonFirstNameProperty);
CFTypeRef ln_typeref = ABRecordCopyValue(person, kABPersonLastNameProperty);

NSString * firstName = (__bridge NSString *) fn_typeref;
NSString * lastName  = (__bridge NSString *) ln_typeref;

NSLog(@"Name:%@ %@", firstName, lastName);

CFRelease(fn_typeref);    // releasing CFTypeRef
CFRelease(ln_typeref);

// use firstName and lastName down here
NSLog(@"Name:%@ %@", firstName, lastName);