Java Hashset.contains() 产生神秘的结果
我通常不使用 Java 编写代码,但最近我开始别无选择。我可能对如何正确使用 HashSet 有一些重大误解。所以我所做的事情可能完全是错误的。不过,我很感激您可能提供的任何帮助。所以实际的问题是:
在我编写的一个小程序中,我生成了非常相似的对象,这些对象在创建时将有一个非常特定的 id(一个 string
或在我的最后一次迭代中一个 长
)。因为每个对象都会产生新的对象,所以我想过滤掉所有已经创建的对象。因此,我开始将每个新对象的 id 放入我的 Hash(Set) 中,并使用 HashSet.contains()
测试是否之前创建了对象。这是完整的代码:
// hashtest.java
import java.util.HashSet;
class L {
public long l;
public L(long l) {
this.l = l;
}
public int hashCode() {
return (int)this.l;
}
public boolean equals(L other) {
return (int)this.l == (int)other.l;
}
}
class hashtest {
public static void main(String args[]) {
HashSet<L> hash = new HashSet<L>();
L a = new L(2);
L b = new L(2);
hash.add(a);
System.out.println(hash.contains(a));
System.out.println(hash.contains(b));
System.out.println(a.equals(b));
System.out.println(a.hashCode() == b.hashCode());
}
}
产生以下输出:
true
false
true
true
所以显然,contains
没有使用L
提供的equals
函数,或者我有一些主要的对概念的误解...
我使用 openjdk(ubuntu 中包含的当前版本)和 Win7 上 Oracle 的官方当前 java 对其进行了测试,
以确保 HashSet.contains()
的官方 java-api 文档的完整性:
公共布尔包含(对象o)
如果该集合包含以下内容,则返回
true
指定元素。更正式地说, 当且仅当此集合时返回true
包含一个元素e
使得(o==null ? e==null : o.equals(e))
.
http:// download.oracle.com/javase/6/docs/api/java/util/HashSet.html#contains(java.lang.Object)
有什么想法或建议吗?
I don't usually code in Java, but recently I started not having a choice. I might have some major misunderstanding of how to properly use HashSet. So it might be possible something I did is just plain wrong. However I'm grateful for any help, you might offer. So the actual problem:
In a small program I was writing, I was generating very similar objects, which, when created, would have a very specific id (a string
or in my last iteration a long
). Because each object would spawn new objects, I wanted to filter out all those I already created. So I started throwing the id of every new object into my Hash(Set) and testing with HashSet.contains()
, if an object was created before. Here is the complete code:
// hashtest.java
import java.util.HashSet;
class L {
public long l;
public L(long l) {
this.l = l;
}
public int hashCode() {
return (int)this.l;
}
public boolean equals(L other) {
return (int)this.l == (int)other.l;
}
}
class hashtest {
public static void main(String args[]) {
HashSet<L> hash = new HashSet<L>();
L a = new L(2);
L b = new L(2);
hash.add(a);
System.out.println(hash.contains(a));
System.out.println(hash.contains(b));
System.out.println(a.equals(b));
System.out.println(a.hashCode() == b.hashCode());
}
}
produces following output:
true
false
true
true
so apparently, contains
does not use the equals
function provided by L
, or I have some major misunderstanding of the concept ...
I tested it with openjdk (current version included in ubuntu) and the official current java from Oracle on Win7
for completeness official java-api documentation for HashSet.contains()
:
public boolean contains(Object o)
Returns
true
if this set contains the
specified element. More formally,
returnstrue
if and only if this set
contains an elemente
such that(o==null ? e==null : o.equals(e))
.
http://download.oracle.com/javase/6/docs/api/java/util/HashSet.html#contains(java.lang.Object)
Any ideas or suggestions?
如果你对这篇内容有疑问,欢迎到本站社区发帖提问 参与讨论,获取更多帮助,或者扫码二维码加入 Web 技术交流群。
绑定邮箱获取回复消息
由于您还没有绑定你的真实邮箱,如果其他用户或者作者回复了您的评论,将不能在第一时间通知您!
发布评论
评论(3)
您的
equals
方法需要采用Object
。因为您将其声明为采用
L
,所以它变成了额外的重载,而不是覆盖该方法。因此,当
hashSet
类调用equals
时,它会解析为基类Object.equals
方法。当您调用equals
时,您会调用重载,因为a
和b
都声明为L< /code> 而不是
Object
。为了防止将来出现此问题,您应该在重写方法时添加
@Override
。这样,如果它实际上不是覆盖,编译器会警告您。
Your
equals
method needs to take anObject
.Because you declared it as taking an
L
, it becomes an additional overload instead of overriding the method.Therefore, when the
hashSet
class callsequals
, it resolves to the baseObject.equals
method. When you callequals
, you call your overload becausea
andb
are both declared asL
instead ofObject
.To prevent this issue in the future, you should add
@Override
whenever you override a method.This way, the compiler will warn you if it isn't actually an override.
您实际上并没有重写
Object.equals
;相反,您正在定义一个具有相同名称但不同参数的新方法。请注意,Object.equals
采用Object
参数,而 equals 方法采用L
参数。如果您重写 equals 方法以获取Object
并在运行时对L
执行必要的类型检查/转换,那么您的代码将按您的预期工作。另外,这就是为什么你真的应该使用
@Override只要您的 JRE 支持,就可以使用
注释。这样,如果您在打算覆盖现有方法时不小心实现了新方法,编译器就会抱怨。举例来说,这个 equals 方法应该可以正常工作。 (并且,在一个不相关的注释中,如果要比较的对象为空,则它不会失败。)
You're not actually overriding
Object.equals
; instead, you're defining a new method with the same name but different parameters. Notice thatObject.equals
takes anObject
argument, while your equals method takes anL
argument. If you rewrite your equals method to take anObject
and perform the necessary type-checking/casting toL
at runtime, then your code is work as you expect.Also, this is why you really should use
@Override
annotations whenever your JRE supports them. That way, the compiler will complain if you accidentally implement a new method when you intend to override an existing one.By way of an example, this equals method should work correctly. (And, on an unrelated note, it won't fail if the object being compared to is null.)
当您将对象添加到集合中时,它会在内部调用
equals
和hashCode
方法。您必须重写这两个方法。例如,我采用了一个带有name
、id
、designation
的 bean 类,然后创建并添加了一个employee
对象。set.add()
在内部调用equals
和hashCode
方法。所以你必须在你的bean类中重写这两个方法。这里我们重写了
equals()
和hashCode()
。当您将对象添加到HashSet
方法时,它会在内部迭代所有对象并调用equals
方法。因此,我们重写hashCode
,它将每个对象hashCode
与其当前hashCode
进行比较,如果两者相等则返回true,否则返回false。When you are adding objects to a set it internally calls
equals
andhashCode
methods. You have to override these two methods. For example I have taken one bean class withname
,id
,designation
, then created and added anemployee
object.set.add()
calls internally theequals
andhashCode
methods. So you have to override these two methods in your bean class.Here we are overriding
equals()
andhashCode()
. When you add an object to theHashSet
method it internally iterates all objects and calls theequals
method. Hence we overridhashCode
, it compares every objectshashCode
with its currenthashCode
and returns true if both are equal, else it returns false.