这段代码对字符串进行非驼峰式大小写有什么问题？

发布于 2024-09-03 17:29:03 字数 1082 浏览 0 评论 0原文

这是我尝试解决About.com Delphi对联合国的挑战-驼峰式大小写字符串。

unit challenge1;

interface

uses
  Windows, Messages, SysUtils, Variants, Classes, Graphics, Controls, Forms,
  Dialogs, StdCtrls;

type
   check = 65..90;
  TForm1 = class(TForm)
    Edit1: TEdit;
    Button1: TButton;
    procedure Button1Click(Sender: TObject);
  private
    { Private declarations }
  public
    { Public declarations }
  end;

var
  Form1: TForm1;
  var s1,s2 :string;
  int : integer;

implementation

{$R *.dfm}

procedure TForm1.Button1Click(Sender: TObject);
var
  i: Integer;
  checks : set of check;
begin
  s1 := edit1.Text;
  for i := 1 to 20  do
  begin
    int  :=ord(s1[i]) ;
    if int in checks then
      insert('  ',s1,i-1);
  end;
  showmessage(s1); 
end;

end.

check 是一个包含大写字母的集合，因此基本上每当遇到大写字母时，插入函数都会在遇到大写字母之前添加空格（在 s1 字符串内），但我的代码不执行任何操作。 ShowMessage 仅显示在 Edit1 中输入的文本。我做错了什么？

原文

Here is my attempt to solve the About.com Delphi challenge to un-camel-case a string.

unit challenge1;

interface

uses
  Windows, Messages, SysUtils, Variants, Classes, Graphics, Controls, Forms,
  Dialogs, StdCtrls;

type
   check = 65..90;
  TForm1 = class(TForm)
    Edit1: TEdit;
    Button1: TButton;
    procedure Button1Click(Sender: TObject);
  private
    { Private declarations }
  public
    { Public declarations }
  end;

var
  Form1: TForm1;
  var s1,s2 :string;
  int : integer;

implementation

{$R *.dfm}

procedure TForm1.Button1Click(Sender: TObject);
var
  i: Integer;
  checks : set of check;
begin
  s1 := edit1.Text;
  for i := 1 to 20  do
  begin
    int  :=ord(s1[i]) ;
    if int in checks then
      insert('  ',s1,i-1);
  end;
  showmessage(s1); 
end;

end.

check is a set that contains capital letters so basically whenever a capital letter is encountered the insert function adds space before its encountered (inside the s1 string), but my code does nothing. ShowMessage just shows text as it was entered in Edit1. What have I done wrong?

分享到QQ

分享到微博

如果你对这篇内容有疑问，欢迎到本站社区发帖提问参与讨论，获取更多帮助，或者扫码二维码加入 Web 技术交流群。

发布评论

需要登录才能够评论，你可以免费注册一个本站的账号。

第七度阳光i 2024-09-10 17:29:03

check 是一个集合，这是正确的，但您尚未为其分配任何值，因此它的值是不确定的。其中没有您期望的字符，因此 in 测试可能总是失败。（编译器没有警告您尚未分配任何 check 吗？）

您并不真的想将 check 定义为子范围类型。相反，您应该将 check 替换为内置的 TSysCharSet类型，这是一组字符。然后像这样分配 check：

check := ['A'..'Z'];

此外，不要使用 int 和 Ord 检查字符串的数值，只需使用 Char直接取值：if s1[i] in check。您还需要使用 Length 函数，以便处理整个字符串，而不是假设输入始终正好是 20 个字符长。您还需要将结果存储到 s1 以外的内容中，因为 Caldon 指出，您不想在修改它的同时仍在从中读取更多字符。

You're correct that check is a set, but you haven't assigned any value to it yet, so its value is indeterminate. There are not the characters you expect in it, so the in test probably always fails. (Didn't the compiler warn you that you hadn't assigned anything check yet?)

You don't really want to define check as a subrange type. Rather, you should replace check with the built-in TSysCharSet type, which is a set of characters. Then assign check like this:

check := ['A'..'Z'];

Furthermore, rather than check the numeric value of the string with int and Ord, just use the Char values directly: if s1[i] in check. You'll also want to use the Length function so you process the entire string instead of assuming that the input will always be exactly 20 characters long. You'll also want to store the result into something other than s1 since, as Caldon points out, you don't want to modify it at the same time that you're still reading more characters from it.

回复收藏 0 原文