有人可以提供有关我的 LotusScript 代理的反馈吗？

Question

您好，我不是开发人员，因此不了解最佳实践。 我创建它是为了绕过日志数据的手动数据复制。 该代理适用于单个提要，我将复制该提要并针对每个其他提要进行调整。 对于指定的提要，它会读取上次处理的日志以及今天和昨天迄今为止处理的文件数。 它还对输入文件夹中的文件进行计数并读取服务器的时区。 每个数据项均以 csv 逗号分隔并通过电子邮件发送，随后托管在网站上。 感谢任何建设性的批评。

Sub Initialize
    Dim customername As String
    Dim servername As String
    Dim feedname As String
    Dim alertthresholdinhours As Integer
    Dim inputfeedpath As String

    ' Set for each feed
    customername = "gRrhio"
    servername = "gRrhioEdge2"
    feedname = "FF Thompson ADT"
    alertthresholdinhours = 6
    inputfeedpath = "\\mhinec\elycon\data\adt\*.*"

    ' Counts files in input folder
    Dim pathName As String, fileName As String
    Dim inputfeedcounter As Integer
    inputfeedcounter = 0
    pathName$ = inputfeedpath
    fileName$ = Dir$(pathName$, 0)
    Do While fileName$ <> ""
        inputfeedcounter = inputfeedcounter + 1
        fileName$ = Dir$()
    Loop

    Dim entry As NotesViewEntry   
    Dim vc As NotesViewEntryCollection
    Dim filesprocessed As Integer
    Dim session As New NotesSession
    Dim db As NotesDatabase
    Dim newDoc As NotesDocument
    Dim rtitem As NotesRichTextItem
    Set db = session.CurrentDatabase
    Dim view As NotesView
    Set view = db.GetView( "Sessions\by Feed" )
    Set newDoc = New NotesDocument( db )
    Set rtitem = New NotesRichTextItem( newDoc, "Body" )
    Dim todaysdate As New NotesDateTime("Today")
    Dim flag As Integer
    Dim counter As Integer
    Dim files As Integer
    Dim errors As Integer
    Dim lastdate As String
    Dim lastdayran As String
    Dim lasttime As String
    Dim lasttimeran As String
    Dim filesp As Integer
    Dim lastdayfiles As Integer
    Dim lastdaysfiles2 As Integer
    Dim terrors As Integer
    Dim lastdayerrors As Integer
    lastdate = ""
    lastdayran = ""
    counter = 0
    flag = 0
    filesp = 0
    lastdayfiles = 0
    lastdaysfiles2 = 0
    terrors = 0
    lastdayerrors = 0

    ' Finds date for last time processed, counts files processed and errors
    While flag = 0
        Dim dateTime As New NotesDateTime(todaysdate.DateOnly)
        Dim keyarray(1) As Variant
        keyarray(0) = feedname
        Set keyarray(1) = dateTime

        Set vc = view.GetAllEntriesByKey(keyarray, False)   
        Set entry = vc.GetFirstEntry

        If entry Is Nothing Then
            Call todaysdate.AdjustDay(-1)
        End If

        While Not entry Is Nothing
            files = 0
            Forall colval In entry.ColumnValues
                If counter = 9 Then
                    counter = 0
                Elseif counter = 8 Then
                    counter = 9
                Elseif counter = 7 Then
                    counter = 8
                Elseif counter = 6 Then
                    errors = Cint(colval)
                    counter = 7
                Elseif counter = 5 Then
                    counter = 6
                Elseif counter = 4 Then
                    files = Cint(colval)               
                    counter = 5
                Elseif counter = 3 Then
                    counter = 4
                Elseif counter = 2 Then
                    counter = 3
                    lasttime = colval
                Elseif counter = 1 Then
                    counter = 2
                    lastdate = colval
                Elseif counter = 0 Then
                    counter =  1
                End If           
            End Forall
            filesp = filesp + files
            terrors = terrors + errors
            Set entry=vc.GetNextEntry (entry)
            flag = 1
        Wend
    Wend
    lastdayfiles = filesp
    lastdayerrors = terrors
    lastdayran = lastdate
    lasttimeran = lasttime

    'Counts previous files processed
    filesp = 0
    terrors = 0
    lastdate = ""
    flag = 0
    Call todaysdate.AdjustDay(-1)   
    While flag = 0
        Dim dateTime2 As New NotesDateTime(todaysdate.DateOnly)
        Dim keyarray2(1) As Variant
        keyarray2(0) = feedname
        Set keyarray2(1) = dateTime2
        Set vc = view.GetAllEntriesByKey(keyarray2, False)   
        Set entry = vc.GetFirstEntry

        If entry Is Nothing Then
            Call todaysdate.AdjustDay(-1)
        End If

        While Not entry Is Nothing
            files = 0
            Forall colval In entry.ColumnValues
                If counter = 9 Then
                    counter = 0
                Elseif counter = 8 Then
                    counter = 9
                Elseif counter = 7 Then
                    counter = 8
                Elseif counter = 6 Then
                    counter = 7
                Elseif counter = 5 Then
                    counter = 6
                Elseif counter = 4 Then
                    files = Cint(colval)               
                    counter = 5
                Elseif counter = 3 Then
                    counter = 4
                Elseif counter = 2 Then
                    counter = 3
                Elseif counter = 1 Then
                    counter = 2
                Elseif counter = 0 Then
                    counter =  1
                End If           
            End Forall
            filesp = filesp + files
            Set entry=vc.GetNextEntry (entry)
            flag = 1
        Wend
    Wend
    lastdaysfiles2 = filesp

    ' Prints line of CSV into body of email
    Call rtitem.AppendText ( customername )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( servername )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( datetime.timezone )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( lastdayran )
    Call rtitem.AppendText ( " " )
    Call rtitem.AppendText ( lasttimeran )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( lastdayfiles )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( lastdayerrors )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( lastdaysfiles2 )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( inputfeedcounter )
    Call rtitem.AppendText ( ", " )
    Call rtitem.AppendText ( alertthresholdinhours )
    Call newDoc.Save( False, True )
    newDoc.Subject = feedname
    ' Running from server line should be
    'newDoc.SendTo = "Ecmon Feedcheck/Ecmonitor@ECMONITOR"
    newDoc.SendTo = "AX1Forward Feedcheck/[email protected]"
    newDoc.Send( False )
End Sub

Answer 1

对于不是开发人员，您可以编写大量代码:)

如果您正在寻找一些课程来开始成为一名优秀的开发人员，那么请采纳 Mitch 的建议（来自评论）并将其分解为子例程。 第 1 课：这里肯定有一些重复代码，将重复代码放入方法（函数或子例程）中总是一个好主意，这样它只存在一次。 计算已处理文件和以前已处理文件的部分看起来很相似，并且可能会放入如下例程中：

Function GetCountFilesProcessed() As Integer

    'code here

End Function

但是，如果我正确理解您的代码，您甚至可以节省对此的需要。 您似乎只是尝试从视图条目的列中获取值，而不是在中间执行那个奇怪的循环。 假设您对第 4 列的值感兴趣。 您可以通过索引访问来简单地获取所需列的值。 例如，您的文件变量可以通过此行直接设置为第 4 列的值

files = Cint(entry.ColumnValues(4))  'check this, it might be 3 if the array is zero based.

无论如何，底线是如果此代码有效，那么您就有了一个良好的开端！

Answer 2

在更多的风格方面，我总是发现，当其他人

1. 在声明部分声明了Option 'Explicit'
2. 时，维护他们的代码会更容易。声明的变量从大约较高到较低（例如, session before db before view before doc)
3. 为注释对象添加前缀及其类型 (docMail, dbMyDatabase, viewOutstandingInvoices)
4. 将所有声明放在顶部之前（有助于在遇到变量时找到声明）
5. 正如其他人提到的，打破它在适用的情况下进入功能/子系统。

您关于复制此代理以解决同一问题的其他实例的评论也提出了一个标志。 尝试找出这些代理之间的共同点，并将这些功能推送到脚本库中。 此类事情在维护代码时可以节省大量时间，因为您不需要考虑每个代理的不同之处（例如，我的更改是否适用于该代理的所有实例，还是仅适用于其中的一些实例？）

Answer 3

你想要更多地分解你的代码......一件小事。 取而代之的

while not item is nothing

是双重否定和流行的脑筋急转弯..写：

do until item is nothing
  ...
loop

这也允许你用 exit do 打破循环

Answer 4

您可以优化两个 ForAll 循环。
这是第一个的样子：

Forall colval In entry.ColumnValues
    Select Case (counter)
        Case 1: lastdate = colval
        Case 2: lasttime = colval
        Case 4: files = Cint(colval) 
        Case 6: errors = Cint(colval)
    End Select
    counter = (counter + 1) Mod 10    
End Forall

这是第二个的样子：

Forall colval In entry.ColumnValues
    if (counter = 4) Then files = Cint(colval)
    counter = (counter + 1) Mod 10
End Forall

Answer 5

关于这一点的注释

    While Not entry Is Nothing
        files = 0            
        Forall colval In entry.ColumnValues
            If counter = 9 Then
                counter = 0
            Elseif counter = 8 Then
                counter = 9
    ....

正如 ken 所说，您可以通过使用entry.ColumnValues(x) 方法获取columnValues，因此不需要对值进行交互。 但; 你本来可以这样做

    While Not entry Is Nothing
        files = 0            
        counter = 0
        Forall colval In entry.ColumnValues
            counter = counter + 1
            Select case counter
                case 6
                    errors = Cint(colval)
      .....
            end select

Answer 6

已经有一些优点了。 如果您有共享公共对象的变量，则要添加到它们，然后创建一个类。 将变量添加到该类中。

因此，不要说：

Dim userFullName as String
Dim age as Integer
Dim addressLine1 as String
' ... etc.

您可以拥有：

Class UserDetails 
  Dim fullName as String
  Dim age as Integer
  Dim addressLine1 as String
  ' ... etc
End Class

和引用：

Dim u as new UserDetails
u.fullName = "full name"
u.age = 22
u.addressLine1 = "1 main street"

这样做的优点是您可以添加方法来操作该数据，并且您知道代码与该对象相关，而不是在您的应用程序中寻找。