什么是“最佳实践”? 用于比较引用类型的两个实例?

发布于 2024-07-05 21:31:07 字数 1160 浏览 10 评论 0 原文

我最近遇到了这个问题,到目前为止,我一直很高兴地重写相等运算符(==)和/或Equals方法,以查看两个引用类型是否实际包含相同的数据(即看起来相同的两个不同实例)。

自从我更多地进行自动化测试(将参考/预期数据与返回的数据进行比较)以来,我一直在更多地使用它。

查看 MSDN 中的一些编码标准指南 我遇到了一篇文章,建议不要这样做。 现在我明白为什么这篇文章这么说(因为它们不是同一个实例),但它没有回答这个问题:

  1. 最好的比较方法是什么两种引用类型?
  2. 我们应该实现IComparable吗? (我还看到提到这应该只保留给值类型)。
  3. 有什么我不知道的接口吗?
  4. 我们应该自己推出吗?

非常感谢 ^_^

更新

看起来我误读了一些文档(这是漫长的一天)并覆盖 等于 可能是正确的选择..

如果您正在实施参考 类型,你应该考虑覆盖 引用类型的 Equals 方法 如果您的类型看起来像基本类型 例如点、字符串、BigNumber、 等等。 大多数引用类型应该 不要重载相等运算符, 即使如果它们覆盖 Equals。 然而, 如果您正在实施参考 旨在具有价值的类型 语义,例如复数 类型,你应该覆盖相等性 运算符。

I came across this recently, up until now I have been happily overriding the equality operator (==) and/or Equals method in order to see if two references types actually contained the same data (i.e. two different instances that look the same).

I have been using this even more since I have been getting more in to automated testing (comparing reference/expected data against that returned).

While looking over some of the coding standards guidelines in MSDN I came across an article that advises against it. Now I understand why the article is saying this (because they are not the same instance) but it does not answer the question:

  1. What is the best way to compare two reference types?
  2. Should we implement IComparable? (I have also seen mention that this should be reserved for value types only).
  3. Is there some interface I don't know about?
  4. Should we just roll our own?!

Many Thanks ^_^

Update

Looks like I had mis-read some of the documentation (it's been a long day) and overriding Equals may be the way to go..

If you are implementing reference
types, you should consider overriding
the Equals method on a reference type
if your type looks like a base type
such as a Point, String, BigNumber,
and so on. Most reference types should
not overload the equality operator,
even if they override Equals. However,
if you are implementing a reference
type that is intended to have value
semantics, such as a complex number
type, you should override the equality
operator.

如果你对这篇内容有疑问,欢迎到本站社区发帖提问 参与讨论,获取更多帮助,或者扫码二维码加入 Web 技术交流群。

扫码二维码加入Web技术交流群

发布评论

需要 登录 才能够评论, 你可以免费 注册 一个本站的账号。

评论(10

习惯成性 2024-07-12 21:31:07

在 .NET 中正确、高效地实现平等并且没有代码重复是很困难的。 具体来说,对于具有值语义的引用类型(即 将等价视为相等的不可变类型),您应该实现 System.IEquatable 接口,您应该实现所有不同的操作(EqualsGetHashCode==!=)。

例如,下面是一个实现值相等的类:

class Point : IEquatable<Point> {
    public int X { get; }
    public int Y { get; }

    public Point(int x = 0, int y = 0) { X = x; Y = y; }

    public bool Equals(Point other) {
        if (other is null) return false;
        return X.Equals(other.X) && Y.Equals(other.Y);
    }

    public override bool Equals(object obj) => Equals(obj as Point);

    public static bool operator ==(Point lhs, Point rhs) => object.Equals(lhs, rhs);

    public static bool operator !=(Point lhs, Point rhs) => ! (lhs == rhs);

    public override int GetHashCode() => HashCode.Combine(X, Y);
}

上面代码中唯一可移动的部分是粗体部分:Equals(Point other) 中的第二行和 GetHashCode()代码>方法。 其他代码应保持不变。

对于不表示不可变值的引用类,不要实现运算符 ==!=。 相反,使用它们的默认含义,即比较对象身份。

代码有意甚至等同于派生类类型的对象。 通常,这可能是不可取的,因为基类和派生类之间的相等性没有明确定义。 不幸的是,.NET 和编码指南在这里不是很清楚。 Resharper 创建的代码(在另一个答案中发布)在这种情况下很容易出现不良行为,因为 Equals (object x)Equals(SecurableResourcePermission x) 将以不同的方式处理这种情况。

为了改变这种行为,必须在上面的强类型 Equals 方法中插入额外的类型检查:

public bool Equals(Point other) {
    if (other is null) return false;
    if (other.GetType() != GetType()) return false;
    return X.Equals(other.X) && Y.Equals(other.Y);
}

Implementing equality in .NET correctly, efficiently and without code duplication is hard. Specifically, for reference types with value semantics (i.e. immutable types that treat equvialence as equality), you should implement the System.IEquatable<T> interface, and you should implement all the different operations (Equals, GetHashCode and ==, !=).

As an example, here’s a class implementing value equality:

class Point : IEquatable<Point> {
    public int X { get; }
    public int Y { get; }

    public Point(int x = 0, int y = 0) { X = x; Y = y; }

    public bool Equals(Point other) {
        if (other is null) return false;
        return X.Equals(other.X) && Y.Equals(other.Y);
    }

    public override bool Equals(object obj) => Equals(obj as Point);

    public static bool operator ==(Point lhs, Point rhs) => object.Equals(lhs, rhs);

    public static bool operator !=(Point lhs, Point rhs) => ! (lhs == rhs);

    public override int GetHashCode() => HashCode.Combine(X, Y);
}

The only movable parts in the above code are the bolded parts: the second line in Equals(Point other) and the GetHashCode() method. The other code should remain unchanged.

For reference classes that do not represent immutable values, do not implement the operators == and !=. Instead, use their default meaning, which is to compare object identity.

The code intentionally equates even objects of a derived class type. Often, this might not be desirable because equality between the base class and derived classes is not well-defined. Unfortunately, .NET and the coding guidelines are not very clear here. The code that Resharper creates, posted in another answer, is susceptible to undesired behaviour in such cases because Equals(object x) and Equals(SecurableResourcePermission x) will treat this case differently.

In order to change this behaviour, an additional type check has to be inserted in the strongly-typed Equals method above:

public bool Equals(Point other) {
    if (other is null) return false;
    if (other.GetType() != GetType()) return false;
    return X.Equals(other.X) && Y.Equals(other.Y);
}
埋葬我深情 2024-07-12 21:31:07

看起来您正在使用 C# 进行编码,它有一个名为 Equals 的方法,您的类应该实现该方法,如果您想使用“这两个指针(因为对象句柄就是指针)”之外的其他指标来比较两个对象,相同的内存地址?”。

我从此处获取了一些示例代码:

class TwoDPoint : System.Object
{
    public readonly int x, y;

    public TwoDPoint(int x, int y)  //constructor
    {
        this.x = x;
        this.y = y;
    }

    public override bool Equals(System.Object obj)
    {
        // If parameter is null return false.
        if (obj == null)
        {
            return false;
        }

        // If parameter cannot be cast to Point return false.
        TwoDPoint p = obj as TwoDPoint;
        if ((System.Object)p == null)
        {
            return false;
        }

        // Return true if the fields match:
        return (x == p.x) && (y == p.y);
    }

    public bool Equals(TwoDPoint p)
    {
        // If parameter is null return false:
        if ((object)p == null)
        {
            return false;
        }

        // Return true if the fields match:
        return (x == p.x) && (y == p.y);
    }

    public override int GetHashCode()
    {
        return x ^ y;
    }
}

Java有非常相似的机制。 equals() 方法是 Object 类的一部分,如果您需要这种类型的功能,您的类会重载它。

对于对象来说,重载“==”可能不是一个好主意,因为通常您仍然希望能够进行“这些是相同的指针”比较。 例如,通常依赖这些来将元素插入到不允许重复的列表中,并且如果该运算符以非标准方式重载,则某些框架内容可能无法工作。

It looks like you're coding in C#, which has a method called Equals that your class should implement, should you want to compare two objects using some other metric than "are these two pointers (because object handles are just that, pointers) to the same memory address?".

I grabbed some sample code from here:

class TwoDPoint : System.Object
{
    public readonly int x, y;

    public TwoDPoint(int x, int y)  //constructor
    {
        this.x = x;
        this.y = y;
    }

    public override bool Equals(System.Object obj)
    {
        // If parameter is null return false.
        if (obj == null)
        {
            return false;
        }

        // If parameter cannot be cast to Point return false.
        TwoDPoint p = obj as TwoDPoint;
        if ((System.Object)p == null)
        {
            return false;
        }

        // Return true if the fields match:
        return (x == p.x) && (y == p.y);
    }

    public bool Equals(TwoDPoint p)
    {
        // If parameter is null return false:
        if ((object)p == null)
        {
            return false;
        }

        // Return true if the fields match:
        return (x == p.x) && (y == p.y);
    }

    public override int GetHashCode()
    {
        return x ^ y;
    }
}

Java has very similar mechanisms. The equals() method is part of the Object class, and your class overloads it if you want this type of functionality.

The reason overloading '==' can be a bad idea for objects is that, usually, you still want to be able to do the "are these the same pointer" comparisons. These are usually relied upon for, for instance, inserting an element into a list where no duplicates are allowed, and some of your framework stuff may not work if this operator is overloaded in a non-standard way.

裸钻 2024-07-12 21:31:07

下面我总结了实现 IEquatable 时需要执行的操作,并提供了各个 MSDN 文档页面的理由。


总结

  • 当需要测试值相等性时(例如在集合中使用对象时),您应该实现 IEquatable 接口,为您的类重写 Object.Equals 和 GetHashCode。
  • 当需要测试引用相等性时,您应该使用operator==、operator!=和Object.ReferenceEquals
  • 您应该仅覆盖 ValueTypes 和不可变的引用类型。

理由

IEquatable

System.IEquatable 接口用于比较对象的两个实例是否相等。 根据类中实现的逻辑来比较对象。 比较结果产生一个布尔值,指示对象是否不同。 这与 System.IComparable 接口形成对比,后者返回一个整数,指示对象值有何不同。

IEquatable 接口声明了两个必须重写的方法。 Equals 方法包含执行实际比较的实现,如果对象值相等则返回 true,如果不相等则返回 false。 GetHashCode 方法应返回一个唯一的哈希值,该值可用于唯一标识包含不同值的相同对象。 使用的散列算法的类型是特定于实现的。

IEquatable.Equals 方法

  • 您应该为您的对象实现 IEquatable,以处理它们存储在数组或通用集合中的可能性。
  • 如果实现 IEquatable,还应该重写 Object.Equals(Object) 和 GetHashCode 的基类实现,以便它们的行为与 IEquatable.Equals 方法的行为一致

重写 Equals() 和运算符 == 的指南(C# 编程指南)

  • x.Equals(x) 返回 true。
  • x.Equals(y) 返回与 y.Equals(x) 相同的值
  • 如果 (x.Equals(y) && y.Equals(z)) 返回 true,则 x.Equals(z) 返回 true。
  • 连续调用 x。 只要 x 和 y 引用的对象未被修改,Equals (y) 就会返回相同的值。
  • x。 Equals (null) 返回 false(仅适用于不可为 null 的值类型。有关详细信息,请参阅 可空类型(C# 编程指南)。)
  • Equals 的新实现不应引发异常。
  • 建议任何重写 Equals 的类也重写 Object.GetHashCode。
  • 建议除了实现 Equals(object) 之外,任何类还为自己的类型实现 Equals(type),以提高性能。

默认情况下,运算符 == 通过确定两个引用是否指示同一对象来测试引用相等性。因此,引用类型不必实现运算符 == 即可获得此功能。 当类型不可变时,即实例中包含的数据无法更改时,重载运算符 == 来比较值相等而不是引用相等可能很有用,因为作为不可变对象,它们可以被视为与 long 相同因为它们具有相同的值。 在非不可变类型中重写运算符 == 不是一个好主意。

  • 重载运算符 == 实现不应引发异常。
  • 任何重载运算符 == 的类型也应该重载运算符 !=。

== 运算符(C# 参考)

  • 对于预定义值类型,如果操作数的值相等,则相等运算符 (==) 返回 true,否则返回 false。
  • 对于字符串以外的引用类型,如果两个操作数引用同一个对象,则 == 返回 true。
  • 对于字符串类型,== 比较字符串的值。
  • 在运算符 == 覆盖中使用 == 比较测试 null 时,请确保使用基对象类运算符。 如果不这样做,就会发生无限递归,导致堆栈溢出。

Object.Equals 方法(对象)

如果您的编程语言支持运算符重载,并且您选择重载给定类型的相等运算符,则该类型必须重写 Equals 方法。 Equals 方法的此类实现必须返回与相等运算符相同的结果

以下准则用于实现值类型

  • 考虑重写 Equals,以获得比 ValueType 上 Equals 默认实现所提供的更高的性能。
  • 如果您重写 Equals 并且该语言支持运算符重载,则必须重载您的值类型的等于运算符。

以下准则用于实现引用类型

  • 如果类型的语义基​​于该类型表示某些值,请考虑重写引用类型上的 Equals。
  • 大多数引用类型不得重载相等运算符,即使它们覆盖 Equals。 但是,如果您要实现旨在具有值语义的引用类型(例如复数类型),则必须重写相等运算符。

其他陷阱

  • 当重写 GetHashCode() 时,请确保在哈希代码中使用引用类型之前测试 NULL。
  • 我遇到了此处描述的基于接口的编程和运算符重载的问题: C# 中基于接口编程的运算符重载

Below I have summed up what you need to do when implementing IEquatable and provided the justification from the various MSDN documentation pages.


Summary

  • When testing for value equality is desired (such as when using objects in collections) you should implement the IEquatable interface, override Object.Equals, and GetHashCode for your class.
  • When testing for reference equality is desired you should use operator==,operator!= and Object.ReferenceEquals.
  • You should only override operator== and operator!= for ValueTypes and immutable reference types.

Justification

IEquatable

The System.IEquatable interface is used to compare two instances of an object for equality. The objects are compared based on the logic implemented in the class. The comparison results in a boolean value indicating if the objects are different. This is in contrast to the System.IComparable interface, which return an integer indicating how the object values are different.

The IEquatable interface declares two methods that must be overridden. The Equals method contains the implementation to perform the actual comparison and return true if the object values are equal, or false if they are not. The GetHashCode method should return a unique hash value that may be used to uniquely identify identical objects that contain different values. The type of hashing algorithm used is implementation-specific.

IEquatable.Equals Method

  • You should implement IEquatable for your objects to handle the possibility that they will be stored in an array or generic collection.
  • If you implement IEquatable you should also override the base class implementations of Object.Equals(Object) and GetHashCode so that their behavior is consistent with that of the IEquatable.Equals method

Guidelines for Overriding Equals() and Operator == (C# Programming Guide)

  • x.Equals(x) returns true.
  • x.Equals(y) returns the same value as y.Equals(x)
  • if (x.Equals(y) && y.Equals(z)) returns true, then x.Equals(z) returns true.
  • Successive invocations of x. Equals (y) return the same value as long as the objects referenced by x and y are not modified.
  • x. Equals (null) returns false (for non-nullable value types only. For more information, see Nullable Types (C# Programming Guide).)
  • The new implementation of Equals should not throw exceptions.
  • It is recommended that any class that overrides Equals also override Object.GetHashCode.
  • Is is recommended that in addition to implementing Equals(object), any class also implement Equals(type) for their own type, to enhance performance.

By default, the operator == tests for reference equality by determining whether two references indicate the same object. Therefore, reference types do not have to implement operator == in order to gain this functionality. When a type is immutable, that is, the data that is contained in the instance cannot be changed, overloading operator == to compare value equality instead of reference equality can be useful because, as immutable objects, they can be considered the same as long as they have the same value. It is not a good idea to override operator == in non-immutable types.

  • Overloaded operator == implementations should not throw exceptions.
  • Any type that overloads operator == should also overload operator !=.

== Operator (C# Reference)

  • For predefined value types, the equality operator (==) returns true if the values of its operands are equal, false otherwise.
  • For reference types other than string, == returns true if its two operands refer to the same object.
  • For the string type, == compares the values of the strings.
  • When testing for null using == comparisons within your operator== overrides, make sure you use the base object class operator. If you don't, infinite recursion will occur resulting in a stackoverflow.

Object.Equals Method (Object)

If your programming language supports operator overloading and if you choose to overload the equality operator for a given type, that type must override the Equals method. Such implementations of the Equals method must return the same results as the equality operator

The following guidelines are for implementing a value type:

  • Consider overriding Equals to gain increased performance over that provided by the default implementation of Equals on ValueType.
  • If you override Equals and the language supports operator overloading, you must overload the equality operator for your value type.

The following guidelines are for implementing a reference type:

  • Consider overriding Equals on a reference type if the semantics of the type are based on the fact that the type represents some value(s).
  • Most reference types must not overload the equality operator, even if they override Equals. However, if you are implementing a reference type that is intended to have value semantics, such as a complex number type, you must override the equality operator.

Additional Gotchas

情愿 2024-07-12 21:31:07

微软似乎改变了他们的态度,或者至少存在关于不重载相等运算符的冲突信息。 根据这篇 Microsoft 文章,标题为“How to: Define Value Equality for a类型:

“== 和 != 运算符可以与类一起使用,即使类没有重载它们。但是,默认行为是执行引用相等性检查。在类中,如果重载 Equals 方法,则应该重载 == 和 != 运算符,但这不是必需的。”

根据 Eric Lippert 在他对我提出的有关 回答中的说法questions/32172273/minimal-code-for-equality-in-c-sharp">C# 中平等的最小代码 - 他说:

“这里遇到的危险是你得到了一个定义为 == 的运算符默认情况下引用相等的情况很容易出现这样的情况:重载的 Equals 方法实现值相等,而 == 实现引用相等,然后您意外地对值相等的非引用相等的事物使用了引用相等。这是一种容易出错的做法,很难通过人工代码审查来发现。

几年前,我研究了一种静态分析算法来统计检测这种情况,我们发现每百万行代码中的缺陷率约为两个实例。在我们研究的所有代码库中,当仅考虑在某些地方重写了 Equals 的代码库时,缺陷率显然要高得多!

此外,还要考虑成本与风险。 如果您已经实现了 IComparable,那么编写所有运算符只是简单的一行代码,不会有错误,也永远不会更改。 这是您要编写的最便宜的代码。 如果要在编写和测试十几个小方法的固定成本与查找和修复使用引用相等而不是值相等的难以发现的错误的无限成本之间进行选择,我知道我会选择哪一个。”

.NET Framework 永远不会对您编写的任何类型使用 == 或 != 但是,如果其他人这样做,会发生什么情况,所以,如果该类是针对第三方的,那么我总是会提供 == 或 != 。 == 和 != 运算符。如果该类仅供组内部使用,我仍然可能会实现 == 和 != 运算符,

我只会实现 <、<=、> 和 。 >= 运算符(如果实现了 IComparable)。仅当类型需要支持排序时才应实现 IComparable - 例如在排序或在有序通用容器(如 SortedSet)中使用时,

如果组或公司制定了不实现的策略 。 == 和 != 运算符 - 那么我当然会遵循该策略,如果存在这样的策略,那么明智的做法是使用标记 == 和 的任何出现的 Q/A 代码分析工具来强制执行它。 != 运算符与引用类型一起使用。

Microsoft appears to have changed their tune, or at least there is conflicting info about not overloading the equality operator. According to this Microsoft article titled How to: Define Value Equality for a Type:

"The == and != operators can be used with classes even if the class does not overload them. However, the default behavior is to perform a reference equality check. In a class, if you overload the Equals method, you should overload the == and != operators, but it is not required."

According to Eric Lippert in his answer to a question I asked about Minimal code for equality in C# - he says:

"The danger you run into here is that you get an == operator defined for you that does reference equality by default. You could easily end up in a situation where an overloaded Equals method does value equality and == does reference equality, and then you accidentally use reference equality on not-reference-equal things that are value-equal. This is an error-prone practice that is hard to spot by human code review.

A couple years ago I worked on a static analysis algorithm to statistically detect this situation, and we found a defect rate of about two instances per million lines of code across all codebases we studied. When considering just codebases which had somewhere overridden Equals, the defect rate was obviously considerably higher!

Moreover, consider the costs vs the risks. If you already have implementations of IComparable then writing all the operators is trivial one-liners that will not have bugs and will never be changed. It's the cheapest code you're ever going to write. If given the choice between the fixed cost of writing and testing a dozen tiny methods vs the unbounded cost of finding and fixing a hard-to-see bug where reference equality is used instead of value equality, I know which one I would pick."

The .NET Framework will not ever use == or != with any type that you write. But, the danger is what would happen if someone else does. So, if the class is for a 3rd party, then I would always provide the == and != operators. If the class is only intended to be used internally by the group, I would still probably implement the == and != operators.

I would only implement the <, <=, >, and >= operators if IComparable was implemented. IComparable should only be implemented if the type needs to support ordering - like when sorting or being used in an ordered generic container like SortedSet.

If the group or company had a policy in place to not ever implement the == and != operators - then I would of course follow that policy. If such a policy were in place, then it would be wise to enforce it with a Q/A code analysis tool that flags any occurrence of the == and != operators when used with a reference type.

有木有妳兜一样 2024-07-12 21:31:07

那篇文章只是建议不要重写相等运算符(对于引用类型),而不是反对重写 Equals。 如果相等检查不仅仅意味着引用检查,那么您应该在对象(引用或值)中覆盖 Equals。 如果您想要一个接口,您还可以实现 IEquatable (由通用集合)。 但是,如果您确实实现了 IEquatable,则还应该覆盖 equals,如 IEquatable 备注部分所述:

如果实现 IEquatable,还应该重写 Object.Equals(Object) 和 GetHashCode 的基类实现,以便它们的行为与 IEquatable.Equals 方法的行为一致。 如果您确实重写了 Object.Equals(Object),则在调用类上的静态 Equals(System.Object, System.Object) 方法时也会调用您的重写实现。 这可确保 Equals 方法的所有调用返回一致的结果。

关于是否应该实现 Equals 和/或相等运算符:

来自 实现等于方法

大多数引用类型不应重载相等运算符,即使它们覆盖 Equals。

来自 实现等于和等于运算符 (==) 的指南

每当您实现相等运算符 (==) 时,请重写 Equals 方法,并使它们执行相同的操作。

这只是说,每当您实现相等运算符时,您都需要覆盖 Equals。 它确实没有表明您在重写Equals 时需要重写相等运算符。

That article just recommends against overriding the equality operator (for reference types), not against overriding Equals. You should override Equals within your object (reference or value) if equality checks will mean something more than reference checks. If you want an interface, you can also implement IEquatable (used by generic collections). If you do implement IEquatable, however, you should also override equals, as the IEquatable remarks section states:

If you implement IEquatable<T>, you should also override the base class implementations of Object.Equals(Object) and GetHashCode so that their behavior is consistent with that of the IEquatable<T>.Equals method. If you do override Object.Equals(Object), your overridden implementation is also called in calls to the static Equals(System.Object, System.Object) method on your class. This ensures that all invocations of the Equals method return consistent results.

In regards to whether you should implement Equals and/or the equality operator:

From Implementing the Equals Method

Most reference types should not overload the equality operator, even if they override Equals.

From Guidelines for Implementing Equals and the Equality Operator (==)

Override the Equals method whenever you implement the equality operator (==), and make them do the same thing.

This only says that you need to override Equals whenever you implement the equality operator. It does not say that you need to override the equality operator when you override Equals.

静赏你的温柔 2024-07-12 21:31:07

对于将产生特定比较的复杂对象,那么实现 IComparable 并在 Compare 方法中定义比较是一个很好的实现。

例如,我们有“车辆”对象,其中唯一的区别可能是注册号,我们使用它进行比较以确保测试中返回的预期值是我们想要的值。

For complex objects that will yield specific comparisons then implementing IComparable and defining the comparison in the Compare methods is a good implementation.

For example we have "Vehicle" objects where the only difference may be the registration number and we use this to compare to ensure that the expected value returned in testing is the one we want.

心碎的声音 2024-07-12 21:31:07

我倾向于使用 Resharper 自动制作的东西。 例如,它为我的一种引用类型自动创建了这个:

public override bool Equals(object obj)
{
    if (ReferenceEquals(null, obj)) return false;
    if (ReferenceEquals(this, obj)) return true;
    return obj.GetType() == typeof(SecurableResourcePermission) && Equals((SecurableResourcePermission)obj);
}

public bool Equals(SecurableResourcePermission obj)
{
    if (ReferenceEquals(null, obj)) return false;
    if (ReferenceEquals(this, obj)) return true;
    return obj.ResourceUid == ResourceUid && Equals(obj.ActionCode, ActionCode) && Equals(obj.AllowDeny, AllowDeny);
}

public override int GetHashCode()
{
    unchecked
    {
        int result = (int)ResourceUid;
        result = (result * 397) ^ (ActionCode != null ? ActionCode.GetHashCode() : 0);
        result = (result * 397) ^ AllowDeny.GetHashCode();
        return result;
    }
}

如果您想覆盖 == 并仍然进行引用检查,您仍然可以使用 Object.ReferenceEquals

I tend to use what Resharper automatically makes. for example, it autocreated this for one of my reference types:

public override bool Equals(object obj)
{
    if (ReferenceEquals(null, obj)) return false;
    if (ReferenceEquals(this, obj)) return true;
    return obj.GetType() == typeof(SecurableResourcePermission) && Equals((SecurableResourcePermission)obj);
}

public bool Equals(SecurableResourcePermission obj)
{
    if (ReferenceEquals(null, obj)) return false;
    if (ReferenceEquals(this, obj)) return true;
    return obj.ResourceUid == ResourceUid && Equals(obj.ActionCode, ActionCode) && Equals(obj.AllowDeny, AllowDeny);
}

public override int GetHashCode()
{
    unchecked
    {
        int result = (int)ResourceUid;
        result = (result * 397) ^ (ActionCode != null ? ActionCode.GetHashCode() : 0);
        result = (result * 397) ^ AllowDeny.GetHashCode();
        return result;
    }
}

If you want to override == and still do ref checks, you can still use Object.ReferenceEquals.

蘸点软妹酱 2024-07-12 21:31:07

我相信,对于 .NET 的设计来说,像检查对象是否相等这样简单的事情有点棘手。

对于结构

1) 实现IEquatable。 它显着提高了性能。

2) 由于您现在拥有自己的 Equals,请重写 GetHashCode,并与各种相等性检查重写 object.Equals 保持一致。

3) 重载 ==!= 运算符不需要虔诚地完成,因为如果您无意中使用 ==!=,但这样做最好与 Equals 方法保持一致。

public struct Entity : IEquatable<Entity>
{
    public bool Equals(Entity other)
    {
        throw new NotImplementedException("Your equality check here...");
    }

    public override bool Equals(object obj)
    {
        if (obj == null || !(obj is Entity))
            return false;

        return Equals((Entity)obj);
    }

    public static bool operator ==(Entity e1, Entity e2)
    {
        return e1.Equals(e2);
    }

    public static bool operator !=(Entity e1, Entity e2)
    {
        return !(e1 == e2);
    }

    public override int GetHashCode()
    {
        throw new NotImplementedException("Your lightweight hashing algorithm, consistent with Equals method, here...");
    }
}

对于班级

来自 MS:

大多数引用类型不应重载相等运算符,即使它们覆盖 Equals。

对我来说, == 感觉就像值相等,更像是 Equals 方法的语法糖。 编写a == b比编写a.Equals(b)直观得多。 我们很少需要检查引用相等性。 在处理物理对象的逻辑表示的抽象级别中,这不是我们需要检查的内容。 我认为 ==Equals 具有不同的语义实际上可能会令人困惑。 我相信首先应该是 == 表示值相等,而 Equals 表示引用(或更好的名称,如 IsSameAs)。 我不想在这里认真对待 MS 指南,不仅因为它对我来说不自然,而且还因为重载 == 不会造成任何重大伤害。这与不覆盖非泛型 EqualsGetHashCode 不同,后者可能会反噬,因为框架不会在任何地方使用 ==,除非我们自己使用用它。 我从不重载 ==!= 中获得的唯一真正好处是与整个框架设计的一致性,而我没有控制。 这确实是一件大事,所以遗憾的是我会坚持下去

使用引用语义(可变对象)

1) 覆盖 EqualsGetHashCode

2) 实现 IEquatable 不是必须的,但如果你有一个那就太好了。

public class Entity : IEquatable<Entity>
{
    public bool Equals(Entity other)
    {
        if (ReferenceEquals(this, other))
            return true;

        if (ReferenceEquals(null, other))
            return false;

        //if your below implementation will involve objects of derived classes, then do a 
        //GetType == other.GetType comparison
        throw new NotImplementedException("Your equality check here...");
    }

    public override bool Equals(object obj)
    {
        return Equals(obj as Entity);
    }

    public override int GetHashCode()
    {
        throw new NotImplementedException("Your lightweight hashing algorithm, consistent with Equals method, here...");
    }
}

具有值语义(不可变对象)

这是棘手的部分。 如果不小心,很容易搞砸。

1) 覆盖 EqualsGetHashCode

2) 重载 ==!= 以匹配 Equals确保它适用于 null

2) 实现 IEquatable 不是必须的,但如果你有一个那就太好了。

public class Entity : IEquatable<Entity>
{
    public bool Equals(Entity other)
    {
        if (ReferenceEquals(this, other))
            return true;

        if (ReferenceEquals(null, other))
            return false;

        //if your below implementation will involve objects of derived classes, then do a 
        //GetType == other.GetType comparison
        throw new NotImplementedException("Your equality check here...");
    }

    public override bool Equals(object obj)
    {
        return Equals(obj as Entity);
    }

    public static bool operator ==(Entity e1, Entity e2)
    {
        if (ReferenceEquals(e1, null))
            return ReferenceEquals(e2, null);

        return e1.Equals(e2);
    }

    public static bool operator !=(Entity e1, Entity e2)
    {
        return !(e1 == e2);
    }

    public override int GetHashCode()
    {
        throw new NotImplementedException("Your lightweight hashing algorithm, consistent with Equals method, here...");
    }
}

要特别注意如果您的类可以继承,情况会如何,在这种情况下,您必须确定基类对象是否可以等于派生类对象。 理想情况下,如果没有派生类的对象用于相等性检查,则基类实例可以等于派生类实例,在这种情况下,不需要检查泛型 Type 相等性。 code>Equals 基类。

一般来说,请注意不要重复代码。 我本可以制作一个通用抽象基类(IEqualized 左右)作为模板,以便更轻松地重用,但遗憾的是在 C# 中,这阻止了我从其他类派生。

I believe getting something as simple as checking objects for equality correct is a bit tricky with .NET's design.

For Struct

1) Implement IEquatable<T>. It improves performance noticeably.

2) Since you're having your own Equals now, override GetHashCode, and to be consistent with various equality checking override object.Equals as well.

3) Overloading == and != operators need not be religiously done since the compiler will warn if you unintentionally equate a struct with another with a == or !=, but its good to do so to be consistent with Equals methods.

public struct Entity : IEquatable<Entity>
{
    public bool Equals(Entity other)
    {
        throw new NotImplementedException("Your equality check here...");
    }

    public override bool Equals(object obj)
    {
        if (obj == null || !(obj is Entity))
            return false;

        return Equals((Entity)obj);
    }

    public static bool operator ==(Entity e1, Entity e2)
    {
        return e1.Equals(e2);
    }

    public static bool operator !=(Entity e1, Entity e2)
    {
        return !(e1 == e2);
    }

    public override int GetHashCode()
    {
        throw new NotImplementedException("Your lightweight hashing algorithm, consistent with Equals method, here...");
    }
}

For Class

From MS:

Most reference types should not overload the equality operator, even if they override Equals.

To me == feels like value equality, more like a syntactic sugar for Equals method. Writing a == b is much more intuitive than writing a.Equals(b). Rarely we'll need to check reference equality. In abstract levels dealing with logical representations of physical objects this is not something we would need to check. I think having different semantics for == and Equals can actually be confusing. I believe it should have been == for value equality and Equals for reference (or a better name like IsSameAs) equality in the first place. I would love to not take MS guideline seriously here, not just because it isn't natural to me, but also because overloading == doesn't do any major harm. That's unlike not overriding non-generic Equals or GetHashCode which can bite back, because framework doesn't use == anywhere but only if we ourself use it. The only real benefit I gain from not overloading == and != will be the consistency with design of the entire framework over which I have no control of. And that's indeed a big thing, so sadly I will stick to it.

With reference semantics (mutable objects)

1) Override Equals and GetHashCode.

2) Implementing IEquatable<T> isn't a must, but will be nice if you have one.

public class Entity : IEquatable<Entity>
{
    public bool Equals(Entity other)
    {
        if (ReferenceEquals(this, other))
            return true;

        if (ReferenceEquals(null, other))
            return false;

        //if your below implementation will involve objects of derived classes, then do a 
        //GetType == other.GetType comparison
        throw new NotImplementedException("Your equality check here...");
    }

    public override bool Equals(object obj)
    {
        return Equals(obj as Entity);
    }

    public override int GetHashCode()
    {
        throw new NotImplementedException("Your lightweight hashing algorithm, consistent with Equals method, here...");
    }
}

With value semantics (immutable objects)

This is the tricky part. Can get easily messed up if not taken care..

1) Override Equals and GetHashCode.

2) Overload == and != to match Equals. Make sure it works for nulls.

2) Implementing IEquatable<T> isn't a must, but will be nice if you have one.

public class Entity : IEquatable<Entity>
{
    public bool Equals(Entity other)
    {
        if (ReferenceEquals(this, other))
            return true;

        if (ReferenceEquals(null, other))
            return false;

        //if your below implementation will involve objects of derived classes, then do a 
        //GetType == other.GetType comparison
        throw new NotImplementedException("Your equality check here...");
    }

    public override bool Equals(object obj)
    {
        return Equals(obj as Entity);
    }

    public static bool operator ==(Entity e1, Entity e2)
    {
        if (ReferenceEquals(e1, null))
            return ReferenceEquals(e2, null);

        return e1.Equals(e2);
    }

    public static bool operator !=(Entity e1, Entity e2)
    {
        return !(e1 == e2);
    }

    public override int GetHashCode()
    {
        throw new NotImplementedException("Your lightweight hashing algorithm, consistent with Equals method, here...");
    }
}

Take special care to see how it should fare if your class can be inherited, in such cases you will have to determine if a base class object can be equal to a derived class object. Ideally, if no objects of derived class is used for equality checking, then a base class instance can be equal to a derived class instance and in such cases, there is no need to check Type equality in generic Equals of base class.

In general take care not to duplicate code. I could have made a generic abstract base class (IEqualizable<T> or so) as a template to allow re-use easier, but sadly in C# that stops me from deriving from additional classes.

清眉祭 2024-07-12 21:31:07

我在这个

例子中使用 IEqualityComparerIEquatable

产品实体:

public class Product : IEquatable<Product>
{
    [Key]
    public int ID { get; set; }

    [Required]
    [MaxLength(50)]
    public string Name { get; set; }

    [Required]
    [MaxLength(50)]
    public string SKU { get; set; }

    [Required]
    [MaxLength(100)]
    public string Description { get; set; }

    [MaxLength(100)]
    public string? ImageKey { get; set; }

    [Precision(18, 2)]
    public decimal UnitPrice { get; set; }

    public static bool operator == (Product? x, Product? y) => x.Equals(y);
    public static bool operator != (Product? x, Product? y) => !x.Equals(y);
    public override int GetHashCode() => new EqualityComparer().GetHashCode(this);
    public bool Equals(Product? other) => new EqualityComparer().Equals(this, other);
    public override bool Equals(object? obj) => new EqualityComparer().Equals(this, obj as Product);
}

产品的平等比较器

public class EqualityComparer : IEqualityComparer<Product>
{
    public bool Equals(Product? x, Product? y)
    {
        if (x is null || y is null) return false;
        if (x.ID <= 0 || y.ID <= 0) return false;
        return x.ID == y.ID;
    }
    public int GetHashCode([DisallowNull] Product obj)
    {
        unchecked
        {
            return (17 * 23) + obj.ID.GetHashCode();
        }
    }
}

通过 LinQ 使用此功能,

products.Where(x => orderedProducts.Contains(x, new EqualityComparer())).ToList()

products.Any(orderedProduct.Equals)

您也可以使用重载运算符,例如:

foreach (var orderedProduct in orderedProducts)
{
     foreach (var product in products)
     {
          if (product == orderedProduct)
          {
              var neededProduct = product 
          }
      }
 }

这可以是使用更干净的方式实现:

foreach (var orderedProduct in orderedProducts)
{
     var neededProduct = products.First(orderedProduct.Equals);
}

I use IEqualityComparer or IEquatable for this

example:

Product Entity:

public class Product : IEquatable<Product>
{
    [Key]
    public int ID { get; set; }

    [Required]
    [MaxLength(50)]
    public string Name { get; set; }

    [Required]
    [MaxLength(50)]
    public string SKU { get; set; }

    [Required]
    [MaxLength(100)]
    public string Description { get; set; }

    [MaxLength(100)]
    public string? ImageKey { get; set; }

    [Precision(18, 2)]
    public decimal UnitPrice { get; set; }

    public static bool operator == (Product? x, Product? y) => x.Equals(y);
    public static bool operator != (Product? x, Product? y) => !x.Equals(y);
    public override int GetHashCode() => new EqualityComparer().GetHashCode(this);
    public bool Equals(Product? other) => new EqualityComparer().Equals(this, other);
    public override bool Equals(object? obj) => new EqualityComparer().Equals(this, obj as Product);
}

Equality Comparer for Product

public class EqualityComparer : IEqualityComparer<Product>
{
    public bool Equals(Product? x, Product? y)
    {
        if (x is null || y is null) return false;
        if (x.ID <= 0 || y.ID <= 0) return false;
        return x.ID == y.ID;
    }
    public int GetHashCode([DisallowNull] Product obj)
    {
        unchecked
        {
            return (17 * 23) + obj.ID.GetHashCode();
        }
    }
}

Use this via LinQ

products.Where(x => orderedProducts.Contains(x, new EqualityComparer())).ToList()

products.Any(orderedProduct.Equals)

you may use overloaded operators for this as well e.g. something like :

foreach (var orderedProduct in orderedProducts)
{
     foreach (var product in products)
     {
          if (product == orderedProduct)
          {
              var neededProduct = product 
          }
      }
 }

this can be achieved using a more clean way :

foreach (var orderedProduct in orderedProducts)
{
     var neededProduct = products.First(orderedProduct.Equals);
}
指尖上的星空 2024-07-12 21:31:07

上面的所有答案都不考虑多态性,通常您希望派生引用使用派生的 Equals,即使通过基本引用进行比较也是如此。 请在此处查看问题/讨论/答案 - 平等和多态性

All the answers above do not consider polymorphism, often you want derived references to use the derived Equals even when compared via a base reference. Please see the question/ discussion/ answers here - Equality and polymorphism

~没有更多了~
我们使用 Cookies 和其他技术来定制您的体验包括您的登录状态等。通过阅读我们的 隐私政策 了解更多相关信息。 单击 接受 或继续使用网站,即表示您同意使用 Cookies 和您的相关数据。
原文